Hi Pierre, I am interested in knowing the reason for your suggestion. On first impression it seems like you would spend a lot of time and effort setting up code analysis on each and every version of OFBiz. Even if you put say a parameterized build it would still need to be linked with each version. I also remember that a lot of my initial setup of jenkins builds and seeing the complexity which evolved slowly out of it made me pull all this logic out into ant build files which the CI server simply calls.
Also isn't code analysis a sort of quality assurance exercise like unit tests which also ship with OFBiz codebase? I am trying to understand your reasoning to see if my builds need to be modified. Regards, Taher Alkhateeb On Jul 9, 2014 1:49 PM, "Pierre Smits" <[email protected]> wrote: > Jacques, > > I don't believe that we should pursue this kind of functionality anymore. > While code analysis report generation with either cobertura or jacopo has > its value, it should not be incorporated into the code base of OFBiz. It > should be incorporated in the CI and code analysis environment. > > Regards, > > Pierre Smits > > *ORRTIZ.COM <http://www.orrtiz.com>* > Services & Solutions for Cloud- > Based Manufacturing, Professional > Services and Retail & Trade > http://www.orrtiz.com > > > On Wed, Jul 9, 2014 at 9:37 AM, Jacques Le Roux < > [email protected]> wrote: > > > Hi Pierre, > > > > Since you have it working locally maybe you could help on > > https://issues.apache.org/jira/browse/INFRA-3590 ? (disclaimer I did not > > re-read yet and don't remember clearly the situation) > > > > Jacques > > > > Le 07/07/2014 10:11, Pierre Smits a écrit : > > > >> Hi All, > >> > >> Over the past weeks we have setup and tested an analysis tool to run on > >> the > >> OFBiz code to get some more insights about the quality of the OFBiz > code. > >> This was a direct result of the request from the devops team(s) of > >> ORRTIZ.COM to strengthen their support. > >> > >> *Building and testing OFBiz Trunk* > >> > >> We already use a CI (for months now) to how a feel for how OFBiz builds > >> and > >> how the tests within the code performs, but insights about the quality > >> were > >> lacking. The new tool enables our devops team(s) to drill down through > the > >> information faster and better to support our customers in a more > efficient > >> en effective way. Our CI pulls changes from the OFBiz SVN (commits) > every > >> day at 01:00 CET. We have setup our CI in such a way that test suites > are > >> executed per component. > >> > >> If you want to see how we support our devops team(s) with respect to CI, > >> please go to http://dev.orrtiz.com/jenkins and have a look. > >> > >> *Analysing code in OFBiz Trunk* > >> > >> We are now able to share the first evolution of our implementation of > the > >> anaysis tool with the community to help contributors to get a better > >> understanding of OFBiz. This analysis process runs daily at 07:00 CET, > >> after the CI has build and tested the changes in OFBiz trunk. > >> > >> If you want to see the analysis results produced by our tools, please > go > >> to: http://dev.orrtiz.com/sonar and have a look. > >> > >> As this is a first evolution, the quality of the information is still to > >> be > >> improved. E.g., Java code coverage (e.g. with Cobertura or JaCoCo) still > >> needs to be implemented. > >> > >> Should you wish further information on how we at ORRTIZ.COM do supports > >> our > >> devops team(s), or have suggestions about how we can improve our > >> contributions to the OFBiz community, feel free to send an email > directly > >> to me. > >> > >> Regards, > >> > >> Pierre Smits > >> > >> *ORRTIZ.COM <http://www.orrtiz.com>* > >> > >> Services & Solutions for Cloud- > >> Based Manufacturing, Professional > >> Services and Retail & Trade > >> http://www.orrtiz.com > >> > >> > > -- > > >
