Hi Rishi, I would suggest when refactoring such classes to apply everything that has to do with visibility including: - Removing public modifiers if not needed on class, method, and field levels - adding private where appropriate - marking classes, methods and fields as final where appropriate - marking method arguments as final where appropriate
So I would consider a private constructor to be just one of a suite of activites that I call them collectively as visibility and mutability which are important to provide real isolation between the components with minimal dependencies. My 2 cents Taher Alkhateeb On Fri, Jun 10, 2016 at 2:22 PM, Rishi Solanki <[email protected]> wrote: > Dear All, > > In past we did same for CatalogWorker, ProductWorker, CategoryWorker, and > UtilMisc classed. Now I think for all the utility, worker, helper classes > having only static members are eligible to have an private constructor with > them to make them non instantiable from anywhere. > > We have log an JIra and added patch for the same. So requesting you to take > a look at OFBIZ-7272 for more details and share your feedback in case we > can do the same for more classes or if any classes we have added should not > be in list. > > Thanks for your help in advance. > > > Rishi Solanki > Manager, Enterprise Software Development > HotWax Systems Pvt. Ltd. > Direct: +91-9893287847 > http://www.hotwaxsystems.com >
