1) rename loadDefault by loadAll2) ask if we want to remove loadAll and testIntegration Gradle tasks and replace them by creating loadAll and testIntegration scripts in tools branch. "Moving" Gradle tasks to tools is complicating things for everybody (notably committers), hence should be discussed in dev ML
Jacques Le 15/06/2017 à 12:33, Taher Alkhateeb a écrit :
Why would removing it complicate things while removing testIntegration is okay? I don't understand? On Jun 15, 2017 12:48 PM, "Jacques Le Roux" <[email protected]> wrote: In my mind it's 2 steps (in the 2nd we would move loadAll to tools) but I'm not much for that, because it complicate things for everybody, not only committers Jacques Le 15/06/2017 à 11:23, Taher Alkhateeb a écrit :I am afraid you misunderstood my suggestion. I suggested removing all shortcut tasks, not renaming them. So either remove everything, or rename loadDefault. What you want to do as I undsrstand is rename loadDefault and remove testIntegration. Weird choice! On Jun 15, 2017 12:03 PM, "Jacques Le Roux" <[email protected]> wrote: Hi, It's near a month I suggested to rename loadDefault by loadAll without negative comments So I'll do it soon and will then ask if we want to move the 2 Gradle tasks "testIntegration" and "loadDefault" as scripts in the tools branch. Though it's not really the antonym of start, I finally have decided to not change "ofbizBackground --shutdown " to ofbizBackground --stop". You just need to get used to it, please speak if you think we should. Jacques Le 20/05/2017 à 14:54, Jacques Le Roux a écrit : OK, we partly came to something unexpected :)There is obviously a majority, in those who answered to the "survey", to prefer loadAll So I suggest that we rename loadDefault to loadAll And then decide if we want to move the 2 Gradle tasks "testIntegration" and "loadDefault" as scripts in the tools branch. Agreed? Jacques Le 15/05/2017 à 20:55, Paul Mandeltort a écrit : Agreed! As a user who mainly pokes through at the top level scripts tointegrate with the rest of my systems, this would be the most clear approach when looking at existing scripts. —P On May 15, 2017, at 10:40 AM, Taher Alkhateeb <[email protected]> wrote: Beautifully said Mike! When we switched to gradle, we dropped all "shortcut" tasks (ant targets) and exposed users directly to the server, thereby combining and issuing commands however the user desires. The only shortcut tasks we left in are "testIntegration" and "loadDefault" because we should be running them before applying every commit. So they are there as a convenience but even then I think removing them is better. If we remove them completely and instead get used to the below command instead: ./gradlew cleanAll "ofbiz --load-data" "ofbiz --test" Then we will be have to understand these commands and avoid shortcuts altogether. Everyone would understand how to control the server and better utilize it to fit their needs. So my recommendation is to actually remove loadDefault and testIntegration. On May 15, 2017 6:12 PM, "Mike" <[email protected]> wrote: gradlew "ofbiz --load-data readers=seed,seed-initial,ext,ext-demo" Just leave it "as-is". These are historical. There is nothing gained but more confusion and out-dating of existing documentation. On Sun, May 14, 2017 at 10:34 PM, Paul Foxworthy <[email protected]> wrote: Hi all,At the risk of bikeshedding... The "data" is redundant. What else would you "load" but "data"? loadAll 1 (best) loadDefault 2 loadAllData 3 loadData 4 (worst) loadData should be infinity. It's meaningless. Cheers Paul Foxworthy On 13 May 2017 at 02:45, Paul Mandeltort <[email protected]> wrote: Sorry, I’m being a jerk and not following your directions so feel free to ignore me, but some unsolicited advice :-)The proposed terms are still ambiguous. One of OFBiz’s biggest problems isthere’s a lot of shorthand and ambiguity which makes it really hard forsomeone who occasionally digs in (like me) to figure out what’s going on.So I’m going to suggest a bit more verbosity:Load-Data-All Load-Data-Demo Load-Data-Seed Load-Data-Seed-Initial Load-Data-External Load-Data-External-Test Load-Data-External-Demo to parallel the concepts in the readme. Then at least you can follow the concepts through the pipeline. Now the naming of those data loading tasksis another function as they are still confusion (seed vs seed initialdescription is confusing!). • seed: OFBiz and External Seed Data - to be maintained along with sourceand updated whenever a system deployment is updated• seed-initial: OFBiz and External Seed Data - to be maintained along withsource like other seed data, but only loaded initially and not updatedwhena system is updated except manually reviewing each line• demo: OFBiz Only Demo Data • ext: External General Data (custom) • ext-test: External Test Data (custom) • ext-demo: External Demo Data (custom) While I’m hardly an expert, I’ve always appreciated the pattern of parameters following a “Verb-Noun-Adjective” format. So in this case, Load= Verb, Data = what, Adjective = what kind of data we’re loading.“ext” is also confusing, since it could be confused for “Extension”, but that’s another discussion probably. If you’re a command-line warriors, you can add gradle autocomplete to Bashand Zsh:https://github.com/gradle/gradle-completion —P On May 12, 2017, 10:35 AM -0500, Jacques Le Roux < [email protected]>, wrote: Hi,Following the discussion in this thread https://s.apache.org/9PBV we agreed to change the name of the Gradle task which load demo and alldata.Before Gradle it was load-demo. It's currently loadDefault and in thediscussion came loadAll, loadData and loadAllData. So I propose an informal vote, more a survey, to decide which name weshould use for this (important) task.Please vote by giving a weight to each of 4 propositions:loadDefault loadAll loadData loadAllData For instance, here is my choice loadDefault 4 loadData 3 loadAll 2 loadAllData 1 which means that I prefer loadAllData over loadAll, etc. So if we agree on the idea, we will pick the name with the smaller cumulated number from participantsThanksJacques --Coherent Software Australia Pty Ltd PO Box 2773 Cheltenham Vic 3192 Australia Phone: +61 3 9585 6788 Web: http://www.coherentsoftware.com.au/ Email: [email protected]
