Hi Wei,
Too bad, I forgot this point and backported before receiving your message :D
I'll change them all, no worries
Cheers
Jacques
Le 01/06/2018 à 02:44, Wei Zhang a écrit :
Hi Jacques,
I have created OFBIZ-10419 on JIRA but I cannot update svn log, please see the
error in the attachment. I am appreciated if you can help to do it.
Kind Regards,
Wei
在 2018/5/31 下午5:35，“Jacques Le Roux”<[email protected]> 写入:
Create a JIRA issue for it and update SVN log fits with me
Thanks to care :)
Jacques
Le 31/05/2018 à 11:10, Wei Zhang a écrit :
> Hi Jacques,
>
> Sorry for the inconvenience.
>
> Should I revert the fix or create a JIRA issue for it and update SVN log?
>
> Kind Regards,
>
> Wei
>
>
> 在 2018/5/31 下午5:01，“Jacques Le Roux”<[email protected]> 写入:
>
> Hi Zhang,
>
> This is a core functionality. Even if it's an edge case, I believe
a Jira would have been appropriate and it should be backported.
>
> Also please follow our best practices regarding commit comment:
>
>
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-CommittingChanges
>
>
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
>
> Thanks
>
> Jacques
>
> Le 31/05/2018 à 03:20, [email protected] a écrit :
> > Author: zhangwei
> > Date: Thu May 31 01:20:54 2018
> > New Revision: 1832577
> >
> > URL: http://svn.apache.org/viewvc?rev=1832577&view=rev
> > Log:
> > A minor fix for serviceEndTime conversion
> >
> > Modified:
> >
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java
> >
> > Modified:
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java
> > URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java?rev=1832577&r1=1832576&r2=1832577&view=diff
> >
==============================================================================
> > ---
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java
(original)
> > +++
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java
Thu May 31 01:20:54 2018
> > @@ -240,7 +240,7 @@ public class CoreEvents {
> > endTime = ts1.getTime();
> > } catch (IllegalArgumentException e) {
> > try {
> > - endTime = Long.parseLong(serviceTime);
> > + endTime = Long.parseLong(serviceEndTime);
> > } catch (NumberFormatException nfe) {
> > String errMsg =
UtilProperties.getMessage(CoreEvents.err_resource, "coreEvents.invalid_format_time",
locale);
> > errorBuf.append(errMsg);
> >
> >
> >
>
>
>
>
> ________________________________
>
> Shinetech Software Inc. (Microsoft Gold Certified Partner)
> - Software Development Solutions.
> - Web Development Solutions.
> - Volume Licensing Solutions.
>
=======================================================================================
>
> Think green- please don't print this e-mail unless you really need to!
>
> Shinetech Disclaimer:
> The information contained in this electronic message and any attached
documents may contain confidential and privileged information that is for the sole
use of the intended recipient(s). If you are not the intended recipient, note that
any unauthorized review, disclosure, copying, distribution, or use of the contents
of this electronic message or any attached documents is prohibited. If you have
received this communication in error, please destroy it and notify Shinetech
immediately.
