Hi Mahi,

First and that's unrelated, for security reason I'd recommend you to rather use 
the last release (18.12.05): https://ofbiz.apache.org/download.html

Only since few months the checkstyle issues are completely resolved in trunk and new 22.01 branch. Or actually a bunch of cases, that should be done later, has been hidden (like too long classes and methods, etc.).

So you should not take care of checkstyle and you can simply set maxerrors in build.gradle to, for instance, 50000, to bypass the check. It's only important for developers.

HTH

Jacques

Le 17/02/2022 à 08:04, Mahi maheshwari a écrit :
Hi,

I'm using ofbiz 18.12.01 with gradle version 6.5.
I had encountered errors with checkstyle file in 
config/checkstyle/checkstyle.xml while running ofbiz a couple of months back.

I have resolved it by using below reference with few warnings.
https://stackoverflow.com/questions/49645147/checkstyle-unable-to-create-root-module
I'm also attaching the checkstyle.xml file in which I have made changes. please 
find the attachment below.
It was working fine in my system but when my colleague running the same ofbiz 
repo in his system, we are encountered with the below error logs.

[maheshwari@maheshwari x-mrp-18.12.01]$ ./gradlew loadAll
> Task :compileJava
> Task :compileGroovy
> Task :processResources
> Task :classes
> Task :jar
> Task :assemble

> Task :checkstyleMain
Checkstyle rule violations were found. See the report at: file:///home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/build/reports/checkstyle/main.html
Checkstyle files with violations: 1061
Checkstyle violations by severity: [error:38793]


> Task :compileTestJava
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/start/src/test/java/org/apache/ofbiz/base/start/OfbizStartupUnitTests.java:34: warning: [deprecation] none() in ExpectedException has been deprecated
    public ExpectedException expectedException = ExpectedException.none();
    ^
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/start/src/test/java/org/apache/ofbiz/base/start/OfbizStartupUnitTests.java:87: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(startupCommands.size(), equalTo(1));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/start/src/test/java/org/apache/ofbiz/base/start/OfbizStartupUnitTests.java:88: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
assertThat(startupCommands.get(0).getProperties().size(), equalTo(3));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/util/collections/MapContextTest.java:99: warning: [deprecation] <T>assertThat(String,T,Matcher<? super T>) in Assert has been deprecated
        assertThat("insertion order of LinkedHashMap is preserved by the 'values' 
method",
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(String,T,Matcher<? super 
T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:43: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.get("foo"), is(nullValue()));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:49: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.get("foo"), hasItem(0));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:51: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.get("foo"), both(hasItem(1)).and(not(hasItem(0))));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:57: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.get("foo"), hasItem(0));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:59: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.get("foo"), hasItems(0, 1));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:66: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.get("foo"), hasItem(0));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:68: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.get("foo"), hasItems(0, 1));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:75: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.getFirst("foo"), is(0));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextTests.java:80: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(m.getFirst("foo"), is(nullValue()));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextAdapterTests.java:59: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(adapter.values(), hasItems(0, 3));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/base/src/test/java/org/apache/ofbiz/base/collections/MultivaluedMapContextAdapterTests.java:60: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(adapter.values().size(), is(2));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/entity/src/test/java/org/apache/ofbiz/entity/DelegatorUnitTests.java:39: warning: [deprecation] none() in ExpectedException has been deprecated
    public ExpectedException expectedException = ExpectedException.none();
    ^
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/common/src/test/java/org/apache/ofbiz/common/GetLocaleListTests.java:65: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(localeStrings(res), hasItems("en_ZA", "fr", "fr_BE", "fr_CA", "fr_FR", 
"fr_LU", "fr_CH"));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/common/src/test/java/org/apache/ofbiz/common/GetLocaleListTests.java:72: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(localeStrings(res),
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/common/src/test/java/org/apache/ofbiz/common/GetLocaleListTests.java:81: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(localeStrings(res), hasItems("en_ZA", "fr", "fr_BE", "fr_CA", "fr_FR", 
"fr_LU", "fr_CH"));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:74: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveURI(ccfg, req),
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:76: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveURI(ccfg, req).size(), is(1));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:103: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveURI(ccfg, req), hasItem(foo));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:107: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveURI(ccfg, req), hasItem(bar));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:119: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveURI(ccfg, req), hasItem(bar));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:133: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveURI(ccfg, req), hasItem(foo));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:145: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveURI(ccfg, req), hasItem(bar));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:180: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveMethod("put", rmaps).get(), 
is(fooPut));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/webapp/src/test/java/org/apache/ofbiz/webapp/control/RequestHandlerTests.java:181: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
            assertThat(RequestHandler.resolveMethod("get", rmaps).get(), 
is(fooAll));
            ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:61: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context), hasItems(a, b));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:62: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context).size(), is(2));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:73: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context), hasItems(a1, a2, b));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:74: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context).size(), is(3));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:85: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context), hasItems(a1, a2));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:86: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context).size(), is(2));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:100: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context), hasItems(a1, a2));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
/home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/FormRendererTest.java:101: warning: [deprecation] <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated
        assertThat(renderer.getUsedFields(context).size(), is(2));
        ^
  where T is a type-variable:
    T extends Object declared in method <T>assertThat(T,Matcher<? super T>)
36 warnings

> Task :compileTestGroovy
> Task :processTestResources NO-SOURCE
> Task :testClasses

> Task :checkstyleTest
Checkstyle rule violations were found. See the report at: file:///home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/build/reports/checkstyle/test.html
Checkstyle files with violations: 6
Checkstyle violations by severity: [error:34]


> Task :test

org.apache.ofbiz.base.util.FileUtilTests > zipReadme FAILED
    java.io.FileNotFoundException at FileUtilTests.groovy:36

59 tests completed, 1 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
file:///home/maheshwari/Desktop/XERUS/Test-mrp/x-mrp-18.12.01/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with 
Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See 
https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 44s

How can I resolve this?

Thank you,
Best Regards,
Maheshwari.

Reply via email to