Just have double-checked everything one more time

Recording download is available only if "Room type" === "Show Recording" is
selected
And I make bug
https://github.com/openmeetings/openmeetings-moodle-plugin/commit/e65c681927c17f09af28f6702b7ac7f25e227004

Should be fixed
(hopefully)

On Tue, 7 Apr 2020 at 21:35, Maxim Solodovnik <solomax...@gmail.com> wrote:

> "modedit.php?add=openmeetings" === mod_form.php of openmeetings plugin
> So fix should work as expected ...
>
>
> On Tue, 7 Apr 2020 at 21:19, Maxim Solodovnik <solomax...@gmail.com>
> wrote:
>
>> Make sense
>> I'll double-check
>>
>> On Tue, 7 Apr 2020 at 18:05, Mikhail Zhmurin <zhmurin.mikh...@gmail.com>
>> wrote:
>>
>>> Ok I noticed another thing, when I'm in edit mode I'm seeing modedit.php
>>> in browser url but the file you've fixed is mod_form.php. mod_form.php is
>>> in the /mod/openmeetings/ folder but modedit.php is in the /course/ folder.
>>> I think I misunderstood you. I talking about button in the screenshot I
>>> attached below, if there' s another way to download recordings from moodle
>>> and I'm addressing wrong page, please let me know
>>> [image: moodle.png]
>>>
>>>
>>> вт, 7 апр. 2020 г. в 06:35, Maxim Solodovnik <solomax...@gmail.com>:
>>>
>>>>
>>>>
>>>> On Tue, 7 Apr 2020 at 00:06, Mikhail Zhmurin <zhmurin.mikh...@gmail.com>
>>>> wrote:
>>>>
>>>>> Ok, I got some new info. If I press f12 and delete " disabled="
>>>>> disabled" in chrome dev tools, .mp4 button becomes active and I'm
>>>>> actually able to download recording and recording plays as it should. As
>>>>> soon as I chose another recording from the list the button becomes 
>>>>> inactive
>>>>> again and  " disabled="disabled" comes back.
>>>>>
>>>>>
>>>> Well,
>>>> Commit I send here do exactly the same
>>>> It makes Download button enable if there is MP4 available
>>>> Maybe it was applied to the wrong place?
>>>>
>>>>
>>>>> пн, 6 апр. 2020 г. в 22:19, Mikhail Zhmurin <zhmurin.mikh...@gmail.com
>>>>> >:
>>>>>
>>>>>> Hello, Maxim.
>>>>>> The fixed you've provided didn't work, but I've noticed that my
>>>>>> streams folder only contains .webm's and FINAL WAVE.wav files. At the 
>>>>>> same
>>>>>> time folder named hibernate contains mp4's is it possible that ffmpeg
>>>>>> doesn't convert files in proper folders and that is the reason I can't
>>>>>> download mp4's from moodle?
>>>>>>
>>>>>
>>>> This is expected behavior
>>>> "Final"  recordings goes to "hibernate" folder
>>>>
>>>>
>>>>>> пт, 3 апр. 2020 г. в 21:02, Maxim Solodovnik <solomax...@gmail.com>:
>>>>>>
>>>>>>> Should be fixed:
>>>>>>>
>>>>>>> https://github.com/openmeetings/openmeetings-moodle-plugin/commit/d547f3c0027208ffde7ee29b2fb1a1fb37ee3be7
>>>>>>>
>>>>>>> On Fri, 3 Apr 2020 at 21:15, Maxim Solodovnik <solomax...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Seems to be reproducible
>>>>>>>> going to investigate
>>>>>>>>
>>>>>>>> On Fri, 3 Apr 2020 at 21:01, Maxim Solodovnik <solomax...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hello Mikhail,
>>>>>>>>>
>>>>>>>>> not yet, please be patient :)
>>>>>>>>>
>>>>>>>>> On Fri, 3 Apr 2020 at 15:08, Mikhail Zhmurin <
>>>>>>>>> zhmurin.mikh...@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Hello, Maxim.
>>>>>>>>>> Have you had a chance to check whether it's possible to
>>>>>>>>>> acces/download recordings from moodle?
>>>>>>>>>>
>>>>>>>>>> пт, 3 апр. 2020 г. в 00:51, R. Scholz <
>>>>>>>>>> rene.sch...@abakus-edv-systems.de>:
>>>>>>>>>>
>>>>>>>>>>> Hello,
>>>>>>>>>>>
>>>>>>>>>>> when I invite someone only with email-address this one get,
>>>>>>>>>>> before
>>>>>>>>>>> entering the room, an input-box who can input his name -
>>>>>>>>>>> preallocated
>>>>>>>>>>> with "Guest".
>>>>>>>>>>> In the newest M4-version (yesterdfay) I see only the tree
>>>>>>>>>>> input-textboxes. No "OK" or something else. Where is it?
>>>>>>>>>>>
>>>>>>>>>>> Best regards,
>>>>>>>>>>>
>>>>>>>>>>> René
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Best regards,
>>>>>>>>> Maxim
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Best regards,
>>>>>>>> Maxim
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Best regards,
>>>>>>> Maxim
>>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Best regards,
>>>> Maxim
>>>>
>>>
>>
>> --
>> Best regards,
>> Maxim
>>
>
>
> --
> Best regards,
> Maxim
>


-- 
Best regards,
Maxim

Reply via email to