1. You could move org.apache.pivot.util.ImmutableIterator to package org.apache.pivot.collections.immutable.

2. The immutable collection classes (ImmutableList/Map/Set) expose their own private List/Set/MapListeners, which makes them completely useless -- never will those listeners report any modification. Instead, the methods getListListeners(), getMapListeners(), getSetListeners() should delegate to the wrapped List/Map/Set instance, so that the users of the immutable view still get reported about modifications of the wrapped collection.

What do you think?

Dirk.



Reply via email to