On 26 March 2011 04:26, Bill van Melle <[email protected]> wrote:
> In an alternate reality, Pivot could end up being a 20mb download with 90% >> of that being Decorator implementations. >> > > Well, sure. My only point was that if Pivot does supply an implementation, > it might as well supply one that works in more cases. > Point taken, and I agree that an improved GrayscaleDecorator that respects transparency, and therefore probably fulfills more use cases, is preferable to one that turns previously transparent pixels black. My issue was with the wording of 'bug' or 'inadequacy'. > I'm wondering if there is (or could be) some kind of repository for user > contributions of little decorators, transitions, and other components that > others could draw on. It would be particularly useful for decorators, which > require some non-trivial graphics expertise. > Likewise for user provided Containers, Components and Skins and probably others things. Perhaps Sandro's recent post might be a starting point http://apache-pivot-users.399431.n3.nabble.com/Pivot-related-sites-on-Apache-Extras-td2712415.html The same 'issue' might apply to other decorators. >> > That had occurred to me, but without trying them out, I'd never know, and > at the moment I only have use for the GrayscaleDecorator :-). > > Anyway, I submitted my mod to GrayscaleDecorator as > https://issues.apache.org/jira/browse/PIVOT-723 > Thanks for the submission. Could you also attach an example image that can be used to compare the results from using the original decorator and one that includes the proposed change? (Be sure to grant permissions for its use). It can also be used to see if other decorators produce unexpected results with images that contain transparency. Or if that is not possible, provide instructions on how to replicate the 'issue' that the improvement will address. Chris
