Ah, I see what you mean. Sure, that makes sense. The biggest benefit of having an actual format that you can use for patches (like something the IDE will understand) is that version control 'noise' is greatly reduced. That is, you can see the real effect of a logic change instead of having to wade through whitespace/formatting changes.
Until now, I've always used spaces for indentation and never tabs. As for the eclipse file, I wouldn't have any information on that - I use IDEA for everything. I'd be happy to post my idea config if people are curious. I think we should create a wiki page for this and have those two files as attachments. Cheers, Les On Wed, Nov 17, 2010 at 9:19 AM, Philippe Laflamme <[email protected]> wrote: > > Hi Les, > > I agree. Personally, my only issue with Sun's convention is that they mix > spaces and tabs for indentation. I think you should pick either one, but not > both. Mixing both results in having the downside of using spaces-only AND > the downsides of using tabs-only indents. > > As a side note, I would suggest to officially pick a code convention for > Shiro and publish the associated Eclipse XML file on the Web Site. Many > open-source projects do this; it helps submitting patches/extensions. > > Thanks, > Philippe > -- > View this message in context: > http://shiro-user.582556.n2.nabble.com/Shiro-code-conventions-tp5747873p5748606.html > Sent from the Shiro User mailing list archive at Nabble.com. >
