Yes please put up a pull request to fix it.

Each supervisor has a given set of ports that a worker can be on.  Each of
those ports is called a slot by the supervisor.  When the supervisor comes
up it needs to recover its state about what was running on it before.  This
message is it just saying that after recovering its state it thinks there
is nothing running in that slot.

There should be a corresponding message for a slot that something is
scheduled on it.  Neither of these is something to be concerned about, I
think I just put them in as warn when I wrote the code to help me debug the
recover code so the log messages would stand out, but I forgot to switch
them to info when I finished with it.

Thanks,

Bobby

On Tue, May 1, 2018 at 10:01 AM Ramin Farajollah (BLOOMBERG/ 731 LEX) <
[email protected]> wrote:

> Bobby,
>
> Thanks for the reply. I'd be glad to submit my first PR to change the log
> level ;)
>
> What does this message mean and does it have any adverse impact on Storm?
>
> WARN Slot [main] - SLOT m:p Starting in state EMPTY - assignment null
>
>
> Ramin
> From: [email protected] At: 04/30/18 11:50:24
> To: Ramin Farajollah (BLOOMBERG/ 731 LEX ) <[email protected]>,
> [email protected]
> Subject: Re: WARN Slot [main] - SLOT m:p Starting in state EMPTY -
> assignment null
>
> Sorry it should not really be a warning, it should just be info level.
>
> On Fri, Apr 27, 2018 at 9:19 AM Ramin Farajollah (BLOOMBERG/ 731 LEX) <
> [email protected]> wrote:
>
>> Hi,
>>
>> I noticed the following WARN message frequently appearing in the logs:
>>
>> WARN Slot [main] - SLOT m:p Starting in state EMPTY - assignment null
>>
>> Examining the source code here:
>>
>> https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java#L145
>>
>> It appears that the message is always logged as a WARN. Also, I
>> understand when assignment is null, state is EMPTY.
>>
>> I'd like to understand what this means and if there are any adverse
>> effects.
>>
>> Thank you
>> Ramin
>>
>
>

Reply via email to