Thanks for the fix. I just merged them in. On Mon, Sep 24, 2018 at 10:50 AM Michal Koziorowski < [email protected]> wrote:
> Thanks, > > I've created PRs for: > > master: https://github.com/apache/storm/pull/2846 > > 1.1.x: https://github.com/apache/storm/pull/2847 > > and 1.x: https://github.com/apache/storm/pull/2848 > > > Best regards, > > Michal > > W dniu 21.09.2018 o 17:41, Bobby Evans pisze: > > You also need to make sure you submit a patch to master. > > On Fri, Sep 21, 2018 at 8:02 AM Stig Rohde Døssing <[email protected]> > wrote: > >> Sounds good. Yes, 1.x-branch is for 1.2.x. >> >> Den fre. 21. sep. 2018 kl. 09.25 skrev Michal Koziorowski < >> [email protected]>: >> >>> Hi, >>> >>> >>> I created issue for updating zookeeper client ( >>> https://issues.apache.org/jira/browse/STORM-3233). >>> >>> Next week, I will try to submit PRs for current storm and 1.1.x and >>> 1.2.x. >>> >>> I see 1.1.x-branch on git. Which one is for 1.2.x. Is it 1.x-branch? >>> >>> >>> Best regards, >>> >>> Michal >>> >>> W dniu 20.09.2018 o 16:30, Stig Rohde Døssing pisze: >>> >>> I don't think there are any open issues/PRs to do it, but I don't see >>> why we couldn't upgrade. Feel free to raise an issue at >>> https://issues.apache.org/jira, and if you want to contribute the >>> patch, please submit a PR to https://github.com/apache/storm/pulls. You >>> can find a guide on how to develop Storm here >>> https://github.com/apache/storm/blob/master/DEVELOPER.md. >>> >>> Den tor. 20. sep. 2018 kl. 09.58 skrev Michal Koziorowski < >>> [email protected]>: >>> >>>> Hi, >>>> >>>> >>>> Question to devs. >>>> Are there any plans to upgrade zookeeper used in Storm? In newest >>>> 3.4.13 release, there is a fix for cloud environments where zookeeper >>>> servers have dynamic ips ( >>>> https://jira.apache.org/jira/browse/ZOOKEEPER-2184). We would really >>>> want to see zookeeper upgraded to remove some of ugly hacks existing on our >>>> servers made to override zookeeper dynamic ips problems. >>>> >>>> Best regards, >>>> Michal >>>> >>>> >>> >
