Yes, you need to put the conn.close() in a finally, something like this

Connection conn = null;
try {
    ...
    conn = ds.getConnection();
    ...
} catch(Exception ex) {

} finally {
    try {
     conn.close();
    } catch(Exception ex) {
         System.err.println(ex);
    }
}

In your way, if there is an exception, the connection will not be closed, because the code will not reach the conn.close() statement.

Marcelo Epstein wrote:

I use the pool like this: (IS IT WRONG??) I think the connection is being closed..

try {
        Context ctx = new InitialContext();
        if (ctx == null)
              throw new Exception("Boom - No Context");

DataSource ds = (DataSource) ctx.lookup("java:comp/env/jdbc/EasyDB");

              if (ds != null) {
                Connection conn = ds.getConnection();
                if (conn != null) {
                        Statement stmt = conn.createStatement();
                        String query ="Any query";
                        ResultSet rs = stmt.executeQuery(query);
                        while (rs.next()) {
                                                              "Use ResulSet"

                        }
                                stmt.close();
                        conn.close();
                }
            }
        } catch (Exception ex) {
                System.out.println(ex.toString());
        }


On Tue, 06 Apr 2004 10:19:15 -0600, "Larry Meadors" <[EMAIL PROTECTED]> escreveu:



De: "Larry Meadors" <[EMAIL PROTECTED]>
Data: Tue, 06 Apr 2004 10:19:15 -0600
Para: <[EMAIL PROTECTED]>
Assunto: Re: Connection Pooling

My bet is on a connection leak - you open one in a try block and don't close it in the finally block.


[EMAIL PROTECTED] 04/06/04 10:08 AM >>>

Hi,


I have just started using Connection Pooling in my app (Tomcat, Struts, DBCP, Mysql) .
It woks for about 20 hours and stop working until tomcat restart.


I get this exception:

org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool exhausted, 
cause:
java.util.NoSuchElementException: Timeout waiting for idle object

I canĚ t fix it. Any advice??

Thanks in advance.
Marcelo



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to