On 7/21/05, Dakota Jack <[EMAIL PROTECTED]> wrote: > This code does not belong to Michael. It is purloined from > www.michaelmcgrady.com and other discussion on this list. Michael did > not even know the reasons for most of the code when he first proposed > it as his own. To think he could have coded it under those > circumstances would be akin to expecting a monkey to randomly type a > novel. So, I would be very hesitant, if I were a committer, to accept > his authority to offer this code.
Jack, we already discussed this. You accused me in stealing your code before I added support for image buttons, and at that time I did not know about your code at all. Later discussion and your accusations made me realise that my code did not support image buttons. Therefore, I added support for image buttons after you mentioned the issue with them. I personally do not use image buttons so I was not aware of ".x"/".y" issues. The code itself does not seem to look like code on your website (do you want me to scan and check every page on your site? The link you provided does not point to specific code). If you look at the copyright notice on top of the class, you will see "Copyright 2001-2005 The Apache Software Foundation." I will be glad to put the same notice on all code located at http://struts.sourceforge.net/strutsdialogs, if committers decide to include this library into core Struts. I also do not claim that I wrote every line in SelectAction class. It is partly borrowed from DispatchAction and LookupDispatchAction. On 7/22/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > 2. History is riddled with examples of 2 or more people inventing/creating > the same (fundamentally the same) thing simultaneously. Dennis, with all due respect, I would not classify stripping a suffix from request parameter as invention. This is just a routine solution of a simple issue. Granted, I did not know about the issue before Jack started accusing me in stealing his code. Now I do know, so I added support for image buttons, based on the discussion. On 7/22/05, Niall Pemberton <[EMAIL PROTECTED]> wrote: > I presume you're referring to the fact that Michael Jouravlev's flavour of > DispatchAction uses the ".x" and ".y" suffixes which HTML appends to image > button parameters to determine the method to execute as being "code > purloined from Michael McGrady"? (If not, then what?) > > I agree that, to my knowledge, Michael McGrady was the first person to > propose this technique on the Struts mailing lists/wiki, but to claim that > it is not possible for anyone else to come up with the same idea and that > they must have "purloined" it from his web site is ridiculous - its not > exactly rocket science. In fact the forerunner of Michael McGrady's idea was > the Struts ImageButtonBean which used similar techniques for the same > purpose. Michael Jouravlev has already stated on this list that he didn't > steal this idea from anyone else and since he wasn't around on the Struts > lists when the ideas were being discussed (about a year ago) I don't see any > reason not to believe him. Um, I stated that I did not steal any of Michael McGrady's ideas or code the first time Jack accused me in stealing. The first version of SelectAction did not deal with image buttons at all. Then, after series of accusations and after discussion about image button issues, I added support for it, based on the discussion. Again, I did that *after* initial accusations, but I do not claim intellectual ownership on solution for image buttons. I want to thank Jack for pointing out to the problems with image buttons. On 7/22/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Let's recognize prior art: http://www.jguru.com/faq/view.jsp?EID=893423 === cut here === Author Ted Husted CreatedMay 27, 2002 An endless source of aggravation is the HTML input image element. The specification says that browsers should treat this control like an image map. Unlike other buttons, it does not submit a string representing the button's label, it submits the X and Y coordinates. If you look at the HTTP post for an image button, you'll see it looks something like this myImageButton.x=200 myImageButton.y=300 For most other controls, a Struts developer can create a simple String property to represent the element. This clearly won't work with an image button, because it submits two "dotted" properties instead of a simple "name=value" entry like other elements. === cut here === Just a note: the above is correct for MSIE; Firefox produces slightly different parameters: myImageButton.x=200 myImageButton.y=300 myImageButton=Log+In Which does not really matter, because it is still important to support MSIE. I also do not really like a solution with a separate action form, it looks too bulky for a simple dispatch. Thus, I just strip the suffix in the action. Michael. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
