Am I experiencing DejaVu? Links that might interest you: http://java.sun.com/blueprints/corej2eepatterns/Patterns/BusinessDelegate.html http://java.sun.com/blueprints/corej2eepatterns/Patterns/DataAccessObject.html (see Figure 9.1) http://www.hibernate.org/ http://www.springframework.org/docs/reference/jdbc.html
-Dennis emre akbas <[EMAIL PROTECTED]> 10/13/2005 10:32 AM Please respond to "Struts Users Mailing List" <[email protected]> To Struts Users Mailing List <[email protected]> cc Subject Struts and db connections :: best practice Hi all, In a well written struts application, we assume declarative exception handling is used. Therefore the code of the action classes will look clean and short (and nice) because all the exception handling is done via the exception-handler classes outside. My question is about db connection management when declarative exception handling is used. A usual scenario is : ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ public class MyAction extends Action { ... public ActionForward execute( . .. ) { .. Connection con = getDataSource().getConnection(); // an exception occurs here and the control passes to the // exception-handler class, which can never close the connection // opened above. .... con.close(); } ... } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ What to do in a situation like above? Since the exception-handler could not close the connection opened in the Action class, this will cause the connections in the pool to be exhausted. To prevent the situation above, we may : ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ public class MyAction extends Action { ... public ActionForward execute( . .. ) { .. Connection con = null; try { con = getDataSource().getConnection(); // an exception occurs here .... } catch(MyAppSpecifiException e) { .... } catch(Exception e) { // IMPORTANT, this line will catch all the exceptions .... } finally { con.close(); } } ... } The scheme above seems to solve the unclosed connection problem but it does not use declarative exception-handling and the code is really messed-up with exception handling statements. It does not look nice, clean and short. The situation is more complicated when you call a service method within the action and that service method throws an exception. I would like to hear your points on this issuse. Thanks in advance. -- Emre Akbas

