Fixed on trunk and 2.0 branch of XWork. musachy
On Tue, Oct 28, 2008 at 10:55 AM, Musachy Barroso <[EMAIL PROTECTED]> wrote: > Indeed. The conversion errors are set on the "fake" stack, and are never > copied back to the original stack. > > musachy > > > On Tue, Oct 28, 2008 at 10:46 AM, David Harland <[EMAIL PROTECTED]>wrote: > >> I know the feeling ;0) >> >> Dave. >> >> >> --- On Tue, 10/28/08, Musachy Barroso <[EMAIL PROTECTED]> wrote: >> >> > From: Musachy Barroso <[EMAIL PROTECTED]> >> > Subject: Re: Struts 2.0.12 has broken Conversion Errors!!! >> > To: "Struts Users Mailing List" <user@struts.apache.org>, >> [EMAIL PROTECTED] >> > Date: Tuesday, October 28, 2008, 3:44 PM >> > Attention Deficit Disorder + Multi-tasking = bad emails >> > >> > :) >> > >> > musachy >> > >> > On Tue, Oct 28, 2008 at 10:35 AM, David Harland >> > <[EMAIL PROTECTED]>wrote: >> > >> > > 2.0.11.1 works. 2.0.12 does not. >> > > >> > > Regards >> > > >> > > Dave >> > > >> > > >> > > --- On Tue, 10/28/08, Musachy Barroso >> > <[EMAIL PROTECTED]> wrote: >> > > >> > > > From: Musachy Barroso <[EMAIL PROTECTED]> >> > > > Subject: Re: Struts 2.0.12 has broken Conversion >> > Errors!!! >> > > > To: "Struts Users Mailing List" >> > <user@struts.apache.org>, >> > > [EMAIL PROTECTED] >> > > > Date: Tuesday, October 28, 2008, 3:32 PM >> > > > Are you sure abut this? I am running 2.0.11.1 on >> > the test >> > > > case that you >> > > > mentioned, and the conversion errors are added to >> > the >> > > > "fieldErrors" map on >> > > > the action. Please note that the action must >> > implement >> > > > ValidationAware, >> > > > otherwise the errors will do get lost. >> > > > >> > > > musachy >> > > > >> > > > On Tue, Oct 28, 2008 at 9:27 AM, Musachy Barroso >> > > > <[EMAIL PROTECTED]> wrote: >> > > > >> > > > > Thanks for reporting, I will look into it. >> > > > > >> > > > > musachy >> > > > > >> > > > > >> > > > > On Tue, Oct 28, 2008 at 6:55 AM, David >> > Harland >> > > > <[EMAIL PROTECTED]>wrote: >> > > > > >> > > > >> Done. >> > > > >> >> > > > >> Thanks >> > > > >> >> > > > >> >> > > > >> --- On Tue, 10/28/08, Nils-Helge Garli >> > Hegvik >> > > > <[EMAIL PROTECTED]> wrote: >> > > > >> >> > > > >> > From: Nils-Helge Garli Hegvik >> > > > <[EMAIL PROTECTED]> >> > > > >> > Subject: Re: Struts 2.0.12 has >> > broken >> > > > Conversion Errors!!! >> > > > >> > To: "Struts Users Mailing >> > List" >> > > > <user@struts.apache.org>, >> > > > >> [EMAIL PROTECTED] >> > > > >> > Date: Tuesday, October 28, 2008, >> > 11:49 AM >> > > > >> > Hi! >> > > > >> > >> > > > >> > If you have found a bug, please >> > register an >> > > > issue in JIRA >> > > > >> > and include >> > > > >> > as much relevant information as >> > possible. >> > > > >> > >> > > > >> > >> > http://struts.apache.org/helping.html#issues >> > > > >> > >> > > > >> > Thanks. >> > > > >> > >> > > > >> > Nils-H >> > > > >> > >> > > > >> > On Tue, Oct 28, 2008 at 11:34 AM, >> > David >> > > > Harland >> > > > >> > <[EMAIL PROTECTED]> >> > wrote: >> > > > >> > > Since upgrading to struts >> > 2.0.12 from >> > > > 2.0.11.1 all >> > > > >> > conversion errors are being lost. >> > > > >> > > >> > > > >> > > Here is a simple example >> > showing this is >> > > > broken! >> > > > >> > > >> > > > >> > > Take the Struts2 blank app for >> > 2.0.11.1. >> > > > Now add a >> > > > >> > simple Action with an Integer >> > property >> > > > testNumber. Now add a >> > > > >> > jsp with a field testNumber. Now >> > put fred in >> > > > testNumber and >> > > > >> > submit. >> > > > >> > > >> > > > >> > > You get 'Invalid field >> > value for >> > > > field >> > > > >> > "testNumber".' >> > > > >> > > >> > > > >> > > Now replace the lib files from >> > the >> > > > 2.0.11.1 struts2 >> > > > >> > blank with the 2.0.12. >> > > > >> > > >> > > > >> > > The Conversion errors now do >> > not get >> > > > displayed. They >> > > > >> > are lost! >> > > > >> > > >> > > > >> > > It appears to be the >> > > > ParametersInterceptor is taking a >> > > > >> > copy of the ValueStack, the >> > conversion errors >> > > > are being set >> > > > >> > on the new stack and therefore >> > lost. >> > > > >> > > >> > > > >> > > Regards >> > > > >> > > >> > > > >> > > David. >> > > > >> > > >> > > > >> > > >> > > > >> > > >> > > > >> > > >> > > > >> > > >> > > > >> > >> > > > >> > --------------------------------------------------------------------- >> > > > >> > > To unsubscribe, e-mail: >> > > > >> > [EMAIL PROTECTED] >> > > > >> > > For additional commands, >> > e-mail: >> > > > >> > [EMAIL PROTECTED] >> > > > >> > > >> > > > >> > > >> > > > >> > >> > > > >> > >> > > > >> > --------------------------------------------------------------------- >> > > > >> > To unsubscribe, e-mail: >> > > > [EMAIL PROTECTED] >> > > > >> > For additional commands, e-mail: >> > > > >> > [EMAIL PROTECTED] >> > > > >> >> > > > >> >> > > > >> >> > > > >> >> > > > >> >> > > > >> > --------------------------------------------------------------------- >> > > > >> To unsubscribe, e-mail: >> > > > [EMAIL PROTECTED] >> > > > >> For additional commands, e-mail: >> > > > [EMAIL PROTECTED] >> > > > >> >> > > > >> >> > > > > >> > > > > >> > > > > -- >> > > > > "Hey you! Would you help me to carry >> > the >> > > > stone?" Pink Floyd >> > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > "Hey you! Would you help me to carry the >> > stone?" >> > > > Pink Floyd >> > > >> > > >> > > >> > > >> > > >> > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: >> > [EMAIL PROTECTED] >> > > For additional commands, e-mail: >> > [EMAIL PROTECTED] >> > > >> > > >> > >> > >> > -- >> > "Hey you! Would you help me to carry the stone?" >> > Pink Floyd >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > > -- > "Hey you! Would you help me to carry the stone?" Pink Floyd > -- "Hey you! Would you help me to carry the stone?" Pink Floyd
