> On 15.02.2016, at 07:43, Hendrik Lücke-Tieke <[email protected]> wrote: > > Welcome to the wonderful world of build systems... > > First, I used git to check out the code from github. But neither that nor > checking out using git svn (the original source) worked correctly, because > -- due to a git feature -- the newlines in > uimafit-core/src/test/resources/data/docs/ unix-newlines.txt.bin were > replaced during checkout. (More details in "lesson 1" ) > > So, would you accept a pull request, which adds a .gitattributes to the > repository, so cloning the source from github will work for people using > windows?
We can add a .gitattributes file. Contribution welcome. > Then I checked out using svn (had to install it for this) Now uimafit-core > builds correctly. But uimafit-maven-plugin breaks because I have maven 3.3.3 > installed. > > So what version of maven would be ok, Richard? And would it be ok, if I > create a pull request which adds a maven wrapper to get rid of the > dependence of a local maven installation (which may be too bleeding edge)? We just hit this issue too and found this: https://issues.apache.org/jira/browse/MNG-5792 Easy workaround: copying the mvn.cmd script to mvn.bat. It should be possible to fix this by using a newer version the invoker plugin, e.g. by adding <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-invoker-plugin</artifactId> <version>2.0.0</version> to the plugins management section of a suitable POM. I'd be happy to accept contributions for these, especially since I hardly ever build uimaFIT on Windows. Now regarding pull requests: Apache UIMA and uimaFIT are SVN-based projects. We accept contributions as patches via the Jira issue tracker or other official Apache infrastructure such as e.g. the mailing list. I don't think that GitHub counts as such. I know that some projects at Apache use git as their primary repository technology, but we don't do that (yet). So for the time being, I don't think we can do much about pull requests, but if you open an issue and attach a patch, that would work [1] Also note https://uima.apache.org/contribution-policy.html Cheers, -- Richard [1] http://issues.apache.org/jira/ > Best, > Hendrik > > > > My Setup: > $ git svn info > URL: https://svn.apache.org/repos/asf/uima/uimafit/trunk > Last Changed Rev: 1721636 > Last Changed Date: 2015-12-24 16:27:15 +0100 (Do, 24 Dez 2015) > > Windows 8.1 german, 64 bit > Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; > 2015-04-22T13:57:37+02:00) > Java version: 1.8.0_51, vendor: Oracle Corporation > > > > > Lesson 1: Don’t check out using git, because > uimafit-core/src/test/resources/data/docs/ unix-newlines.txt.bin will have > newlines exchanged when using git. > ===== > > Failing tests are: > - org.apache.uima.fit.factory.JCasBuilderTest.test(JCasBuilderTest.java:71) > - > org.apache.uima.fit.testing.factory.TokenBuilderTest.testNewlinesFromFile(To > kenBuilderTest.java:204) > - CasDumpWriterTest.test:57 > - JCasBuilderTest.test:71 > > > Lesson 2: Don’t use maven 3.3.3, because they have removed the mvn.bat... > === > [INFO] --- maven-invoker-plugin:1.8:run (integration-test) @ > uimafit-maven-plugin --- > [INFO] Building: default\pom.xml > [INFO] ..FAILED (0.0 s) > [INFO] Maven invocation failed. Error configuring command-line. Reason: > Maven executable not found at: > C:\Users\hatieke\bin\apache-maven-3.3.3\bin\mvn.bat > > > > > > >> -----Ursprüngliche Nachricht----- >> Von: Richard Eckart de Castilho [mailto:[email protected]] >> Gesendet: Sonntag, 14. Februar 2016 11:50 >> An: [email protected] >> Betreff: Re: uimafit builds broken? >> >> So I just did a build locally and it worked good including the > uimafit-maven- >> plugin module. >> >> What is failing for you exactly? >> >> What operating system/system language/Java version are you using? >> >> How are you building? >> >> Cheers, >> >> -- Richard >> >>> On 14.02.2016, at 01:50, Hendrik Lücke-Tieke <[email protected]> wrote: >>> >>> Whoops - last mail went out in a hurry. I assume the main problem is >>> that uimafit-maven-plugin wont build... >>> >>> Best, >>> Helt >
