Hi,
Could I please get a code review for my fix for: 7096459 convmv says our perl is buggy http://monaco.us.oracle.com/detail.jsf?cr=7096459 Webrev is at: http://jurassic.us.oracle.com/~richb/7096459-v1/ x86 Workspace (with just the component in question built) is at: /net/stard.us.oracle.com/tank/ws/UL/7096459/ (The configure/build/install/publish transcript is in a file called 'publish-trans.txt' in the component directory). See the Bugster CR for the description and evaluation of this bug. When we've reached consensus on the best way to handle this, I'll update the bug report with a Suggested Fix. With the above change, what we now get is: $ convmv convmv 1.14 - converts filenames from one encoding to another Copyright (C) 2003-2008 Bjoern JACKE <[email protected]> This program comes with ABSOLUTELY NO WARRANTY; it may be copied or modified under the terms of the GNU General Public License version 2 or 3 as published by the Free Software Foundation. USAGE: convmv [options] FILE(S) -f enc encoding *from* which should be converted -t enc encoding *to* which should be converted -r recursively go through directories -i interactive mode (ask for each action) --nfc target files will be normalization form C for UTF-8 (Linux etc.) --nfd target files will be normalization form D for UTF-8 (OS X etc.) --qfrom be quiet about the "from" of a rename (if it screws up your terminal e.g.) --qto be quiet about the "to" of a rename (if it screws up your terminal e.g.) --exec c execute command instead of rename (use #1 and #2 and see man page) --list list all available encodings --lowmem keep memory footprint low (see man page) --nosmart ignore if files already seem to be UTF-8 and convert if posible --notest actually do rename the files --replace will replace files if they are equal --unescape convert%20ugly%20escape%20sequences --upper turn to upper case --lower turn to lower case --parsable write a parsable todo list (see man page) --help print this help $ In other words, the fleas line at the beginning is gone. Thanks. _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
