Hi Craig,

> First thanks for doing this.

Thank you for looking at the change.


> 1) components/perl512/patches/01-CVE-2011-2728.patch
>   46 +       ,"6991604 Problem with utility/perl"
> 
>   Why did you put this entry when we're talking about 7111771?

Copy and paste error. Nicely spotted!

> 2) And please make the patch names consistent
>    01-CVE-2011-2728.patch
>    CVE-2011-2939.patch
> 
>      You don't have an ordering problem so you can drop the 01- from the
>      first name.

Sounds good. Will change both things.

> Otherwise looks fine.

May I use your LGTM for SRU gate too, please?

Thank you
-- 
        Vlad
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to