Rich,
Removed the version from Legacy "desc" string..
updated webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/clone/Nov16//webrev/index.html
Thanks,
-Srini
On 11/22/11 05:38, Rich Burridge wrote:
On 11/22/2011 02:13 AM, Srinivasa Sarva wrote:
Rich,
Thanks for the review. Comments inline....
updated webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/clone/Nov16//webrev-1/index.html
...
.../components/nmap/nmap.p5m
* Please lose the extra space after the "dir" in all the dir actions.
It will then make it easier to see exactly what's changed.
Done...
I noticed that the locale files are now under /usr/share/zenmap/locale/...
rather than /usr/share/locale/... This seems fine (X11 and vpanels do
it too).
I can see from the contortions you had to go through in the previous
version of the .p5m file, that you had to map them from one place to
another.
* Line 501. Remove the version number in the legacy "desc" string.
I thought its the format of legacy "desc" string to include
version, I'm just
following other components in terms of format..
I just changed that.
7060335 several components contain version in their legacy actions'
descriptions
http://monaco.us.oracle.com/detail.jsf?cr=7060335
Done....
.../components/nmap/patches/001.configure.patch
.../components/nmap/patches/005.configure.patch
.../components/nmap/patches/006.configure.patch
.../components/nmap/patches/007.configure.patch
.../components/nmap/patches/008.configure.patch
.../components/nmap/patches/002.Makefile.in.patch
.../components/nmap/patches/003.Makefile.in.patch
.../components/nmap/patches/004.Makefile.in.patch
.../components/nmap/patches/009.Makefile.in.patch
* I really don't like the naming of these patches. Can something
more distinguishable be used? Perhaps a dot separated pathname.
So components/nmap/patches/007.configure.patch would become
nsock.src.configure.patch
Agree, changed the file name to path name.
Thanks. I like that much better.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
