Hi - I cross checked the affected components against and re-ran the checks.
http://monaco.us.oracle.com/detail.jsf?cr=7007636
LGTM :-)
------
(Side note: Is there any reason why texinfo currently uses a .copyright
file rather than .license?)
Showing my working :-
ebeasant@minitosh:/net/stard.us.oracle.com/tank/ws/UL/7007636/components$ grep
-l "GNU Free Documentation License" */*license*| wc -l
44
ebeasant@minitosh:/net/stard.us.oracle.com/tank/ws/UL/7007636/components$ grep
"dir path=usr/share/info" */*.p5m | wc -l
40
Have usr/share/info in manifest, but no license file:
common/gcmn.pm5 <- common package, no files delivered, no license needed
(delivers directory).
texinfo/texinfo.p5m <- does deliver .info files, does this require the
license - license is in .copyright file.
The following have GNU Free Documentation License in the license file,
but no usr/share/info directory in manifest.
I'm guessing the they do not necessarily correlate - one can have the
doc license and not necessarily deliver into usr/share/info:
gcc3
gcc45
libidn
mysql-5-1
php-5_2
wireshark
zip
$ grep -l "GNU Free Documentation License" */*license
a2ps/a2ps.license
aalib/aalib.license
autoconf/autoconf.license
autogen/autogen.license
bash/bash.license
binutils/binutils.license
bison/bison.license
coreutils/coreutils.license
diffutils/diffutils.license
flex/flex.license
gawk/gawk.license
gcc3/gcc.license
gcc45/gcc45.license
gdb/gdb.license
gettext/gettext.license
ggrep/gnu-grep.license
gnump/gmp.license
gnupg/gnupg.license
gnuplot/gnuplot.license
gperf/gperf.license
gpgme/gpgme.license
gtar/gtar.license
guile/guile.license
gzip/gzip.license
libassuan/libassuan.license
libidn/libidn.license
libksba/libksba.license
libtool/libtool.license
m4/m4.license
make/make.license
mpc/mpc.license
mpfr/mpfr.license
mysql-5-1/mysql-51.license
php-5_2/php-52.license
pinentry/pinentry.license
quagga/quagga.license
readline/readline.license
screen/screen.license
sed/sed.license
wget/wget.license
which/which.license
wireshark/wireshark.license
xorriso/xorriso.license
zip/info-zip.license
ebeasant@minitosh:/net/stard.us.oracle.com/tank/ws/UL/7007636/components$ grep
"dir path=usr/share/info" */*.p5m
a2ps/a2ps.p5m:dir path=usr/share/info
aalib/aalib.p5m:dir path=usr/share/info
autoconf/autoconf.p5m:dir path=usr/share/info
autogen/autogen.p5m:dir path=usr/share/info
bash/bash.p5m:dir path=usr/share/info
binutils/binutils.p5m:dir path=usr/share/info
bison/bison.p5m:dir path=usr/share/info
common/gcmn.p5m:dir path=usr/share/info
coreutils/coreutils.p5m:dir path=usr/share/info
diffutils/diffutils.p5m:dir path=usr/share/info
emacs/gnu-emacs.p5m:dir path=usr/share/info
flex/flex.p5m:dir path=usr/share/info
gawk/gawk.p5m:dir path=usr/share/info
gdb/gdb.p5m:dir path=usr/share/info
gettext/gettext.p5m:dir path=usr/share/info
ggrep/gnu-grep.p5m:dir path=usr/share/info
gnump/gmp.p5m:dir path=usr/share/info
gnupg/gnupg.p5m:dir path=usr/share/info
gnuplot/gnuplot.p5m:dir path=usr/share/info
gperf/gperf.p5m:dir path=usr/share/info
gpgme/gpgme.p5m:dir path=usr/share/info
gtar/gtar.p5m:dir path=usr/share/info
guile/guile.p5m:dir path=usr/share/info
gzip/gzip.p5m:dir path=usr/share/info
libassuan/libassuan.p5m:dir path=usr/share/info
libksba/libksba.p5m:dir path=usr/share/info
libtool/libtool.p5m:dir path=usr/share/info
m4/m4.p5m:dir path=usr/share/info
make/make.p5m:dir path=usr/share/info
mpc/mpc.p5m:dir path=usr/share/info
mpfr/mpfr.p5m:dir path=usr/share/info
pinentry/pinentry.p5m:dir path=usr/share/info
quagga/quagga.p5m:dir path=usr/share/info
readline/readline.p5m:dir path=usr/share/info
screen/screen.p5m:dir path=usr/share/info
sed/sed.p5m:dir path=usr/share/info
texinfo/texinfo.p5m:dir path=usr/share/info
wget/wget.p5m:dir path=usr/share/info
which/which.p5m:dir path=usr/share/info
xorriso/xorriso.p5m:dir path=usr/share/info
-------- Original Message --------
Subject: [userland-discuss] Code review request for CR #7007636
Date: Thu, 17 Nov 2011 13:45:38 -0800
From: Rich Burridge <[email protected]>
To: Userland-Discuss <[email protected]>
Hi,
Could I please get a code review for my fix for:
7007636 several copyright files need an update to include FDL
http://monaco.us.oracle.com/detail.jsf?cr=7007636
Webrev is at:
http://jurassic.us.oracle.com/~richb/7007636-v1/
x86 Workspace is at:
/net/stard.us.oracle.com/tank/ws/UL/7007636/
I did a "nightly" build earlier today. Log files for this are under:
/net/stard.us.oracle.com/tank/ws/UL/7007636/i386/nightly/logs.2011-11-17.08:41/
See the Bugster CR for more details.
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
