On 12/02/2011 12:38 AM, Marcel Telka wrote:
...
Yes, good point. So changed. New webrev at:
http://jurassic.us.oracle.com/~richb/7076617-v2/
Rich,
I think we should do something with this (just above your change in the
muttbug.sh file):
echo "(Note: This is the build environment installed on the system"
echo "muttbug is run on. Information may or may not match the environment"
echo "used to build mutt.)"
I think something like "C compiler version information" instead of "C compiler
version information for the system that built mutt" would be enough.
That was deliberate. I wanted to clearly differentiate that the C
compiler information was for the system that built mutt. I left
the preceding text there to indicate that (apart from the CFLAGS
line) the other information probably wasn't. I think this text should
stay.
Please remove an extra line before the "XXX-CUSAGE-XXX" mark.
Okay. Done.
New webrev at:
http://jurassic.us.oracle.com/~richb/7076617-v3/
if anybody wants to double check what I've changed.
Please consider to add some note to the PATCHES file. I am not sure we really
want this one in the PATCHES file, but we should at least think about it :-).
Okay. I've thought about it. I'm not adding anything. :-)
I see you have added an upstream ticket for this problem
that hasn't been resolved yet.
I'll update that bug report with the way we've fixed it and
then hopefully this'll turn up for real in a future version of
mutt.
OTOH, the change is simple and straightforward (I thought about something more
complicated, but more generic). Thank you!
You're welcome.
Thanks for the review.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
