Anyone like to review this? Thanks.
-------- Original Message -------- Subject: [userland-discuss] Code review request for CR #6645310 Date: Thu, 22 Dec 2011 12:04:34 -0800 From: Rich Burridge <[email protected]> To: Userland-Discuss <[email protected]> Hi, Could I please get a code review for my fix for: 6645310 idn includes<idn-int.h> instead of<idn/idn-int.h> http://monaco.us.oracle.com/detail.jsf?cr=6645310 Webrev is at: http://jurassic.us.oracle.com/~richb/6645310-v1/ x86 workspace (with just libidn built) is at: /net/stard.us.oracle.com/tank/ws/UL/6645310/ As this is a patch of a patch file, it might be easier to just look at the new patch file: /net/stard.us.oracle.com/tank/ws/UL/6645310/components/libidn/patches/002-includes.patch Configure/build/install/publish transcript at: /net/stard.us.oracle.com/tank/ws/UL/6645310/components/libidn/publish-trans.txt I haven't updated the bug report yet until we have reached a concensus on the best way of fixing this. The test case example in the bug description now compiles currently, but what I believe this does mean (as it currently stands), is that libidn now has a dependency on the libidn package being installed on the system before it can be built. Until we get userland-component-build-in-a-zone implemented, is there a better way of fixing this? Thanks. _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
