On Jan 20, 2012, at 10:30 AM, Petr Cvachoucek wrote: > Hi Shawn, Lukas, > thank you for looking at it. The "editable" attribute is there > from the introduction of the file into the userland gate. > Because pkg(5) doesn't have it and this texinfo manifest was > the only package where I see it, I'd say it is there by mistake. > > I'm removing it, updated webrev is here: > http://tbd.cz.oracle.com/~pcvachou/webrevs/7121463-userland-texinfo/ >
This LGTM … Lukas > Thank you again for spotting this! > Petr > ------ Original Message ------ > From: "Shawn Walker" <[email protected]> > To: "Lukas Rovensky" <[email protected]> > Cc: "Petr Cvachoucek" > <[email protected]>;[email protected] > Sent: 19.1.2012 18:34:38 > Subject: Re: [userland-discuss] Code review request for CR 7121463 >> On 01/19/12 08:17, Lukas Rovensky wrote: >>> Hi Petr, >>> >>> I was just curios about the difference in attributes between: >>> >>> components/texinfo/texinfo.p5m >>> 136 -file usr/share/info/dir path=var/info/usr_sfw_share_info_dir >>> mode=0644 editable=true preserve=true >>> >>> and >>> >>> components/gcc3/gcc-3.p5m >>> 441 +file usr/sfw/share/info/dir path=var/info/usr_sfw_share_info_dir >>> mode=0644 editable=true preserve=true >>> pkg.linted.pkglint.dupaction001.1=true >>> >>> The comments in CR 7121462 answered my question, so LGTM. >> >> pkg(5) doesn't have any attribute called "editable". Why is that >> attribute being set? >> >> -Shawn >> > _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
