The code looks ok to me. Because this change is so important I would recommended at least a 2nd pair of eyes.
I'm still working on the php test results. They look pretty close to what I generated months ago but I'm producing a new baseline now to see where we stand. So more to come from me on this. craig ----- [email protected] wrote: > The nightly build for x86 has now completed. Logs are under: > > > /net/stard.us.oracle.com/tank/ws/UL/autotools-update/i386/nightly/logs.2012-01-30.07:18/ > > The only failure is python27, which hard-wires the version of > autoconf > it needs in .../components/python/python27/patches/00-bits.patch > > Initially the CBE that builds Userland when these changes integrate, > will be the > one based on Solaris 11 (FCS), so that means that this patch cannot be > applied > until the Userland CBE uses the new autoconf. I've reverted the change > to this > file, opened a new bug (CR #7141080) and generated a new webrev: > > http://jurassic.us.oracle.com/~richb/autotools-update-v2/ > > Thanks. > > > -------- Original Message -------- > Subject: Code review request for autoconf and automake updates. > Date: Mon, 30 Jan 2012 10:28:14 -0800 > From: Rich Burridge <[email protected]> > To: Userland-Discuss <[email protected]> > CC: Brian Cameron <[email protected]>, "[email protected]" > <[email protected]> > > > > Hi all, > > Could I please get a code review for the changes for: > > 6886388 Ship automake-1.11.2 > http://monaco.us.oracle.com/detail.jsf?cr=6886388 > > 7127352 autoconf should be updated to the latest version > http://monaco.us.oracle.com/detail.jsf?cr=7127352 > > 7132411 Various Userland components will need adjusting when > autoconf > and automake are updated > http://monaco.us.oracle.com/detail.jsf?cr=7132411 > > Webrev is at: > > http://jurassic.us.oracle.com/~richb/autotools-update-v1/ > > x86 workspace is at: > > /net/stard.us.oracle.com/tank/ws/UL/autotools-update/ > > SPARC workspace is at: > > /net/wonderland.us.oracle.com/builds/richb/autotools-update/ > > (I have full nightly builds going in each of those workspaces at the > moment, which will hopefully be finished this afternoon). > > Userland successfully builds with these new autoconf and automake > packages. Alan Coopersmith has confirmed that the X consolidation > builds too. The Desktop group is in the process of testing them on > their consolidation. > > There are currently two versions of automake available (1.9.6 and > 1.10). > Userland and X will not need these versions when automake 1.11.2 > integrates. > Until it can be shown that this is also true for Desktop, then the > plan is that the new version of automake will be an addition version > (and the default one). > > See the Bugster CR's for more details. > > Thanks. > > > _______________________________________________ > userland-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/userland-discuss _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
