On 01/30/12 14:15, Danek Duvall wrote:
Here's an update to vim:https://cr.opensolaris.org/action/browse/userland/dduvall/vim-next/ The patch should be reviewed as well -- it configures, compiles, and runs, but a code review would be very nice. Thanks, Danek _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
The Makefile and manifest seem completely straightforward. The patch appears to be adding support for ZFS ACLs, and based on how small the change are, I'd say its fine, particularly the configure changes, which I trust based on your having built it. It's a bit hard to evaluate the changes to os_unix.c from the patch diffs. Are there before/after copies of os_unix.c online anywhere so that the surrounding code context can be seen? - Ali _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
