I give this a +1.
One thing I will note, though, about automake. Note this upstream
issue:
https://trac.transmissionbt.com/ticket/1072
http://lists.gnu.org/archive/html/bug-automake/2008-09/msg00007.html
http://www.mail-archive.com/[email protected]/msg01217.html
In other words, if you build a module with automake that does not have
a COPYING file, it adds a GPLv3 one for you.
It might make more sense to make automake use "foreign" strictness on
Solaris by default instead of "gnu" strictness, so it avoids doing this.
Personally, I do not think it is very nice that automake tries to
automagically pick a free license for you. Really, choosing a license
should involve some actual consideration from the author, I'd think.
Brian
On 01/30/12 06:52 PM, Rich Burridge wrote:
On 01/30/2012 04:32 PM, Alan Coopersmith wrote:
On 01/30/12 10:28 AM, Rich Burridge wrote:
Hi all,
Could I please get a code review for the changes for:
6886388 Ship automake-1.11.2
http://monaco.us.oracle.com/detail.jsf?cr=6886388
7127352 autoconf should be updated to the latest version
http://monaco.us.oracle.com/detail.jsf?cr=7127352
7132411 Various Userland components will need adjusting when autoconf
and automake are updated
http://monaco.us.oracle.com/detail.jsf?cr=7132411
Webrev is at:
http://jurassic.us.oracle.com/~richb/autotools-update-v1/
Besides the discussion we already had about changing the new package name
from -1112 to just -111, I also noticed:
- I assume the doc removal from -110 is because they're now being shipped
in -111 instead. It looks like you could also drop a couple more dir
entries from -110 now that are also no longer needed:
dir path=usr/share/doc
dir path=usr/share/doc/automake
Indeed. So changed. A new webrev with this change
(and the change of the automake 1.11.2 package name from:
pkg:/developer/build/automake-1112 to
pkg:/developer/build/automake-111
which is mentioned above) can be found at:
http://jurassic.us.oracle.com/~richb/autotools-update-v3/
I've rebuilt those two components in my x86 workspace. Final package
manifests can be found at:
/net/stard.us.oracle.com/tank/ws/UL/autotools-update/components/automake/automake-1.10/build/manifest-i386-automake.published
/net/stard.us.oracle.com/tank/ws/UL/autotools-update/components/automake/automake-1.11.2/build/manifest-i386-automake.published
- I wonder if a bunch of the components where you run aclocal, autoconf,
automake, etc. could be reduced to autoreconf, but would have to go
look up
the differences before pushing for it instead of just wondering.
I did experiment with this for a couple of the components as I was
trying to fix
them up, but was unsuccessful. This is certainly worth revisiting,
especially
when we also have the new version of libtool integrated into Userland
(CR #6936997) in a future build.
Thanks for the review (and you too Craig).
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
