Rich,
Thanks for the review.
Comments below.
On 02/10/12 14:26, Rich Burridge wrote:
On 02/10/2012 12:13 PM, Srinivasa Sarva wrote:
Please review the changes (simple) for
CR7144665 Upgrade pv to 1.2.0
Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/Feb10/webrev/index.html
You forgot to update the Copyright in the Makefile.
Done...
Why does the Makefile have:
test: $(NO_TESTS)
?
Both the existing version and the new one you are planning to
update to have a set of tests that could be run.
My mistake. Updated the Makefile.
I didn't do the existing version and followed the same for new version.
I'll double check from now.
Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/Feb10/webrev/index.html
Thanks
Srini
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
