Lukas,
thank you for the review!
Petr
On 15.2.2012 10:30, Lukas Rovensky wrote:
Hi Petr,
this LGTM.
Lukas
On Feb 13, 2012, at 9:58 AM, Petr Cvachoucek wrote:
Hi all,
Could I please get a code review for the Gutenprint update:
6948608 Update Gutenprint to version 5.2.7
http://monaco.us.oracle.com/detail.jsf?cr=6948608
Webrev is at:
http://sfwcfi.us.oracle.com/builds/pcvachou/gutenprint-6948608-default/webrev/
The introduced patch tests-env.patch is needed for tests to pass.
Its purpose is to:
1) Set the STP_MODULE_PATH and STP_DATA_PATH environment variables when
executing tests - without this, gutenprint modules are not found by
the test script (the test script looks for modules in source directory,
but we're building out-of-sources) and all tests fail.
2) Do not treat missing translations as an error when testing generated PPD
files. There's no way to point the cupstestppd utility to not-yet-installed
translation files, so the test doesn't find some translations.
The test log can be found here:
http://sfwcfi.us.oracle.com/builds/pcvachou/gutenprint-6948608-default/components/gutenprint/test.log
Thank you
Petr
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
