Hey Rich,
I'm no wxWidgets expert but based on the bug contents and what you've
noted here the change looks fine.
Just need to update the copyright year in the Makefile.
Thanks,
Kevin.
On 02/23/12 01:14 PM, Rich Burridge wrote:
Hi all,
Could I please get a code review for the changes for:
7147876 wxrc unusable in Solaris 11 Update 1 (build #9)
http://monaco.us.oracle.com/detail.jsf?cr=7147876
Webrev is at:
http://jurassic.us.oracle.com/~richb/7147876-v1/
x86 workspace with the various changes in is at:
/net/stard.us.oracle.com/tank/ws/UL/7147876/
wxwidgets new (working) build log is in:
/net/stard.us.oracle.com/tank/ws/UL/7147876/component/wxwidgets/publish-trans.txt
wxwidgets old (broken) build log is in:
/net/stard.us.oracle.com/tank/ws/UL/7147876/component/wxwidgets/publish-trans.txt.old
Tested by installing the new package and running the wxrc command again:
$ wxrc frame.xrc
$
Creating a C++ source file from the frame.xrc file works nicely too:
$ wxrc frame.xrc -v -c -o frame.cpp
processing frame.xrc...
creating C++ source file
/export/home/richb/userland/bugs/6906419/examples/frame.cpp...
$
This will also allow:
6906419 wxrc should generate code which is possible to compile by
Sun Studio 12
http://monaco.us.oracle.com/detail.jsf?cr=6906419
to work correctly.
See the Bugster CR's for more details.
Thanks.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
