On 03/08/2012 04:31 AM, Stacey Marshall - Solaris Software wrote:
On 03/07/12 20:52, Rich Burridge wrote:
Hi all,
Could I please get a code review for:
7101897 libtool contains some automount paths
http://monaco.us.oracle.com/detail.jsf?cr=7101897
Webrev is at:
http://jurassic.sfbay/~richb/7101897-v1/
...
The fix is to substitute lines in libtool (a script file) once placed
in PROTO directories.
The substitution is to the whole lines that begin with 'LTCC="' or
'CC="'.
Not quite. There are several CC="" lines in the libtool scripts that I
want to remain as they are. I just want to adjust the ones that start
with "LTCC="/some/path/to/cc" (1 of them) and "CC="/some/path/to/cc"
(2 of them).
I'm interested as I know /usr/sbin/named also captures some
pathnames. While your fix won't help me it is food for thought.
Your changes look OK, I wonder though if a targeted replacement that
allowed for characters after the pathname would be more future proof?
For example
$ echo 'CC="/some/path/to/cc" # comment' > test
$ echo 'XX="XX" # comment' >> test
$ /usr/gnu/bin/sed -e 's|^CC="[^"]*|CC="cc|' test
CC="cc" # comment
XX="XX" # comment
$
That's certainly another approach, but I think I've got enough to
fix this. This is certainly enough to handle the libtool scripts that
have been in use since 1.5.22 (June 2007) through to the latest
one 2.4.2 (Oct 2011).
Thanks for the review.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
