Craig,
Okay, looks good.
Thanks,
April
On 03/ 8/12 02:29 PM, Craig Mohrman wrote:
Thanks for the review April.
----- april.c...@oracle.com wrote:
Hi Craig,
components/git/Makefile:
68 # Some issues around I18N that some are known.
The wording is a little awkward in this comment. Did you mean
something
like:
There are some known issues around I18N.
Right. What you said.
80 cd $(BUILD_DIR)/man1 ; for manfile in *.1; \
81 do \
82 name=`basename $$manfile .1`; \
83 sed -e 's/\\m\[blue\]//g' -e 's/\\m\[\]//g'
$$manfile> $(PROTOUSRSHAREMAN1DIR)/$$name.1; \
84 done
There are references to section 5 and section 7 manpages in these
section 1 manpages,
which need to be changed, respectively, to section 4 and section 5
manpages to go along
with your manpage section moves, so you'll need the same
substitutions here to fix them that you used for sections 4 and 5.
Also, there are a few references to gitglossary(7) and gitdiffcore(7)
in
some section 4 manpages,
and githooks(5), gitrepository-layout(5) are also referenced in
section
5 manpages, but they've moved to
section 4. So section 4 and 5 manpages will also need additional
substitution commands for sed.
Ok ok. You're forcing me to think now.
The rest looks okay to me.
I hope so...
Full review:
http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_git/webrev/index.html
Incremental:
http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_git/webrev-incr/index.html
Thanks again,
craig
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
