Hi, Thanks for the reviews (both on-list and off-list).
After further discussion on this (off-list), we are going with a different approach. Rather than modify the mapfile for libexslt to add in the four new symbols, the component Makefile has been adjusted to build the libexslt library without a mapfile. As components in Userland are updated frequently, and have Uncommitted interfaces, it was thought that this was a better fit and less likely to get us into a repeat of this situation at a future date. To minimize the changes we are making as we come up to the end of a build cycle, we are just adjust the libexslt library generation for now. The new webrev at: http://jurassic.us.oracle.com/~richb/7153397-v2/ x86 code workspace (with just libxslt rebuilt) is at: /net/stard.us.oracle.com/tank/ws/UL/7153397/ New build/publish log is: /net/stard.us.oracle.com/tank/ws/UL/7153397/components/libxslt/publish-trans.txt SPARC Userland workspace (with just libxslt rebuilt) is at: /net/wonderland.us.oracle.com/builds/richb/7153397/ New build/publish log is: /net/wonderland.us.oracle.com/builds/richb/7153397/components/libxslt/publish-trans.txt I've successfully repeated the various tests I'd previous run. Thanks. -------- Original Message -------- Subject: [userland-discuss] Fairly urgent code review request for CR #7153397 Date: Tue, 13 Mar 2012 08:21:01 -0700 From: Rich Burridge <rich.burri...@oracle.com> To: Userland-Discuss <userland-discuss@opensolaris.org> Hi, Can I have a fairly urgent code review for my fix for: 7153397 libexslt is built incorrectly http://monaco.us.oracle.com/detail.jsf?cr=7153397 As we want to update the Python lxml bindings in Userland, (CR #7153019) and this fix is going to be needed as part of the CBE for doing that, then it needs to get in sooner rather than later. Webrev is at: http://jurassic.us.oracle.com/~richb/7153397-v1/ x86 code workspace (with just libxslt built) is at: /net/stard.us.oracle.com/tank/ws/UL/7153397/ Build/publish log is: /net/stard.us.oracle.com/tank/ws/UL/7153397/components/libxslt/publish-trans.txt SPARC Userland workspace (with just libxslt built) is at: /net/wonderland.us.oracle.com/builds/richb/7153397/ Build/publish log is: /net/wonderland.us.oracle.com/builds/richb/7153397/components/libxslt/publish-trans.txt See the test related comments in the Bugster CR for how I tested this. Thanks. _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
