On 16.4.2012 15:22, Edwin Beasant wrote:
On 6.4.2012 11:39, Petr Cvachoucek wrote:
Hi Mike, all,
I'd like to ask for a code review for these bugfixes for GNU make 3.82.
7159246 gmake target-specific variables fail if over 150 characters
and contain semicolon
http://monaco.us.oracle.com/detail.jsf?cr=7159246
- this bug is not (yet) fixed in upstream, bugreport and patch
are submitted here:
http://savannah.gnu.org/bugs/index.php?36106
7158488 MAKEFLAGS not being honored always (regression) in 3.82
http://monaco.us.oracle.com/detail.jsf?cr=7158488
- these upstream bugs are related to this (fixed in upstream CVS):
https://savannah.gnu.org/bugs/?30723
https://savannah.gnu.org/bugs/?33873
https://savannah.gnu.org/support/index.php?107487
Fix looks good, all tests passed (no regressions), and patched version
now works against the 7159246 test case:
-bash-4.1$ ./make -f ~/test.mk
a;
eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee
-bash-4.1$
(Thats a pass :-)
As a side note, would it be possible to add a test to the test suite to
specifically check these cases?
Hi Edwin,
thank you for the review, I'll try to take a look at the test suite (and
submit a patch to upstream when I'll have a working test).
Petr
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
