Looks good, Rich.
Thanks,
April
On 04/20/12 11:36 AM, Rich Burridge wrote:
Hi April,
rdiff-backup/rdiff-backup.copyright:
please remove the TPNO # line, since there isn't one yet
components/rdiff-backup/patches/deprecation.patch (deleted):
This patch adds the -Wignore::DeprecationWarning option to the
rdiff-backup & rdiff-backup-statistics scripts, to ignore warnings
about deprecated features in python.
I think you may have removed this patch because DeprecationWarnings
are ignored
by default now in Python2.7. They are not ignored by default in
Python2.6, so
unless we do want to see deprecation warnings now, you'll want to
keep this patch,
at least for the Python2.6 scripts.
Okay. I've made those two changes. New webrev at:
http://jurassic.us.oracle.com/~richb/7161380-v2/
The rest looks good to me.
Thanks!
On 04/17/12 11:31 AM, Rich Burridge wrote:
Hi,
Could I please get a code review for the changes for:
7161380 Update rdiff-backup to version 1.3.3
http://monaco.us.oracle.com/detail.jsf?cr=7161380
Webrev is at:
http://jurassic.us.oracle.com/~richb/7161380-v1/
x86 Userland workspace is at:
/net/stard.us.oracle.com/tank/ws/UL/7161380/
Build/publish log is:
/net/stard.us.oracle.com/tank/ws/UL/7161380/components/rdiff-backup/publish-trans.txt
SPARC Userland workspace is at:
/net/wonderland.us.oracle.com/builds/richb/7161380/
Build/publish log is:
/net/wonderland.us.oracle.com/builds/richb/7161380/components/rdiff-backup/publish-trans.txt
Tested by installing the rdiff-backup packages and running some
of the examples given in the
.../components/rdiff-backup/rdiff-backup-1.3.3/examples.html webpage.
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
