----- [email protected] wrote: > Hi, > > > as far as I can tell it looks ok. You basically updated CGI.pm > files > > with latest version (or the version I see in 5.16). > > It might be nice to put this information to the top of the patch. >
Ok. I'll put that somewhere. > > > > >http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_perl-sec-7030196/webrev/ > > I like how you separated the patchlevel.h changes into separate > patch. > Clever move! Thanks. I basically had to because the ordering of the patches became important since nearly every patch touches patchlevel.h and MANIFEST so breaking it out made it easy to modify and now easier to remember that I have to do it. I should have done the same with MANIFEST. Next time. > > LGTM (and I guess some backporting work to S11, S10, S9 and maybe S8 > for > me :) ) Thanks Vlad. Sorry for adding to your workload. craig _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
