On 06/27/2012 01:13 PM, johan...@opensolaris.org wrote:
On Wed, Jun 27, 2012 at 12:37:19PM -0700, Rich Burridge wrote:
On 06/27/2012 11:08 AM, Krister Johansen wrote:
Hi Rich,
On Wed, Jun 27, 2012 at 06:22:05AM -0700, Rich Burridge wrote:
Webrev is at:
http://jurassic.us.oracle.com/~richb/UL-7155369-v1/
Webrev is at:
http://jurassic.us.oracle.com/~richb/ON-7155369-v1/
Most of these changes look fine to me; however, I had a little trouble
with the patch in the userland workspace, and the mdb module. Can I
impose upon you to post a diff of the python2.6 versus python2.7
versions of both the patch and the mdb module?
Sure they are at:
http://jurassic.us.oracle.com/~richb/UL-7155369-v1/mdb.diffs
If you want to look directly at the patch files (and/or compare them
in some other way), then I created this with:
$ cd /net/stard.us.oracle.com/tank/ws/UL/7155369/components/python
$ gdiff -urN python26/patches/Python26-20-py_db.patch
python27/patches/14-py_db.patch >
/home/richb/public_html/UL-7155369-v1/mdb.diffs
Thanks, can I also trouble you for the diff between the mdb modules?
The diff in the link seems to just be the patch.
Ah, sorry. I misunderstood. Diff files are under:
http://jurassic.us.oracle.com/~richb/UL-7155369-v1/26-27/
(created with
/net/stard.us.oracle.com/tank/ws/UL/7155369/components/python/do_diffs.sh).
In the patch, you build gdbhooks. That looks new to 2.7, and removed
from 2.6. Is it needed?
I suspect not. This part of the patch was created "by hand" because the
existing
Python-2.7.X/Makefile.pre.in chunk in the ...-py_db.patch file failed
when I tried to
apply it to Python-2.7.X/Makefile.pre.in. So I just worked in the
changes we needed
and then generated that patch chunk which was grafted into 14-py_db.patch.
It seemed the simplest thing to do. (Until we added in this patch, we
certainly have
been building the "gdbhooks" target.)
Everthing else in those diffs looks fine.
Okay.
Thanks.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
