Hi there, I've stumbled across an issue whereby any IPS macro that is passed to 
pkgmogrify with whitespace in it is mangled by the ips.mk makefile:
 Line 86 in the make-rules/ips.mk is the following:

PKG_OPTIONS +=      $(PKG_MACROS:%=-D %)

Which is intended to prefix all the macros with -D for passing to pkgmogrify.
The problem comes when, for example, the HUMAN_VERSION string is something like 
"93u  2011-02-08": The result is "93u -D 2011-02-08" in the macro passed to the 
pkgmogrify rule.

This isn't really suitable for things like ksh93 where the human readable 
version string is "93u  2011-02-08", and anything else would not be following 
upstream's version ing.

Even quoting the version string will fail here, as it is a simple search and 
replace on the entire composed PKG_MACROS string, which will not respect 
quoting in this case.

I've checked that supplying a quoted sting direct to pkgmogrify works as 
expected, it just how to get the string complete with quotes all the way to the 
pkgmogrify command line without being violated en route :-)

Two questions:
 1. Which category can CR/RFE for the Userland build system be filed under?
 2. How can we work around the pattern substitution rule without  forcing every 
rule that appends to PKG_MACROS to manually place -D in front?

Any suggestions gratefully received!
Cheers,
Edwin
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to