Hi Srini,

Thanks...your latest changes look fine to me.

April

On 09/10/12 12:36 PM, Srinivasa Sarva wrote:
April,

Thanks for the review. Comments below.

On 09/07/12 17:50, April Chin wrote:
Hi Srini,

The 6 new patches seem to be replacing the old
patches/10-arphrd-infiniband.patch, breaking each file in that patch into a separate patch file, so I expected to see patches/10-arphrd-infiniband.patch as being deleted in the webrev.

Is there some reason we want these in separate patch files? Since as a set, they
fix one problem--
    7003338 infiniband adapters do not work with tcpdump
it makes sense to keep it grouped as one patch file.

My mistake, I was confused because userland decided to have separate patch files in patch directory. but what you said makes sense too since they together fix one issue. I updated the webrev to
        reflect one patch

        Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/S11U2/WS2/webrev/


      -Srini




Thanks,
April
On 09/ 6/12 02:11 PM, Srinivasa Sarva wrote:
Hi all,

Please review the changes for
7196707 Update tcpdump to 4.3.0

Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/S11U2/WS2/webrev/

Thanks
Srini
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to