Hey Petr,

components/tomcat/patches/build.properties.patch

  24  # ----- Tomcat native library -----
  25 @@ -126,16 +132,16 @@
  26  
tomcat-native.win.1=${base-tomcat.loc.1}/tomcat-connectors/native/${tomcat-native.version}/binaries/tomcat-native-${tomcat-native.version}-win32-bin.zip
  27  
tomcat-native.win.2=${base-tomcat.loc.2}/tomcat-connectors/native/${tomcat-native.version}/binaries/tomcat-native-${tomcat-native.version}-win32-bin.zip
  28  

These look odd for Solaris but I guess no stranger than before.

  24  # ----- Tomcat native library -----
  25 @@ -129,16 +135,16 @@
  26  tomcat-native.dll.x64=${tomcat-native.home}/tcnative-1.dll.x64
  27  tomcat-native.dll.i64=${tomcat-native.home}/tcnative-1.dll.i64
  28  


components/tomcat/patches/build.xml.patch

  28 -    <antcall target="downloadzip-2">
  29 -      <param name="sourcefile.1" value="${tomcat-native.win.1}"/>
  30 -      <param name="sourcefile.2" value="${tomcat-native.win.2}"/>

Same comment.

Why do we need these Windows things?

The rest is fine.


craig


----- [email protected] wrote:

> Hi,
> 
> can somebody please review this?
> 
> https://cr.opensolaris.org/action/browse/userland/xsumbe00/tomcat-15990838/
> 
> Thanks,
> 
> Petr
> _______________________________________________
> userland-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to