On 02/ 9/13 12:59 AM, Brian Cameron wrote:
Why is the jdbc41.patch not in the patches subdirectory? Shouldn't
patches have comments to point out things like the fact the patch
was taken from Fedora, and why?
jdbc41.patch cannot be in patches directory because it doesn't patch
main Tomcat source tree. It patches the other archive - dbcp
subcomponent (see changed build.xml).
By adding comment into patch about its source I would actually modify
the patch. Now it's 100% the same file as it's used in Fedora. Plus so
far there are no rules which would require that.
Thanks,
Petr
On 02/ 6/13 09:06 AM, Petr Sumbera wrote:
Hi,
can somebody please review this?
https://cr.opensolaris.org/action/browse/userland/xsumbe00/tomcat-16024185/
Following patch from Fedora project was taken as is to make it happen:
http://pkgs.fedoraproject.org/cgit/apache-commons-dbcp.git/tree/jdbc41.patch
My change also makes sure that Java 7 is used at run time (in all cases).
Thanks,
Petr
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
