Done, see TRINIDAD-1107 Regards, Cedric Durmont
2012/7/12 Andrew Robinson <[email protected]>: > Okay, thanks. Since the attribute is only used by the DesktopRendered, > would you mind applying the new attribute to CoreTable instead of > Table? That way renderkits that extend Trinidad, but not it's core > renderers will not be broken by the addition of a new attribute. > > Thanks. > > On Thu, Jul 12, 2012 at 3:40 AM, Cédric Durmont <[email protected]> wrote: >> Actually the height is set on a <div> tag containing the <table>. The >> header&footer are outside the div, so they don't scroll. The JS part >> is used to keep column widths in sync between header, body and footer, >> so you can still use percentages in width. >> >> Right now I just took the generated code for a scrollable table and >> put in in w3c validator, the fragment is _almost_ HTML 4.01 valid (2 >> errors in column rendering, which I didn't modify : the validator is >> complaining about the 'with' and 'nowrap' attributes, both >> non-existent in the specs) >> I have one more error in the XHTML validation : my <col> tags are not >> closed. I generate them with the following code : >> --- >> writer.startElement("col", null); >> writer.writeAttribute(XhtmlConstants.WIDTH_ATTRIBUTE, >> colData.getWidth(i), null); >> writer.endElement("col"); >> --- >> I could manually add the closing tag, or maybe there's a way to do it >> using the writer api, but I don't know how. >> >> Anyway, the scrollable tr:table has been tested here on IE 8&9, >> Firefox and Chrome. (Our clients use them with IE, but we're currently >> validating our app to run on Firefox) >> >> >> >> 2012/7/12 Andrew Robinson <[email protected]>: >>> Is the height attribute or height style being set on a <TABLE> HTML >>> element? If so that is not valid. The TABLE element has no height, >>> neither an attribute nor support for a CSS height. Some browsers >>> recognize, others do not, but it is not in the HTML specification as a >>> current attribute. >>> >>> http://www.w3.org/TR/html4/struct/tables.html >>> >>> As you can see, the height attribute is deprecated on the TH/TD, but >>> there is no height attribute on the TABLE element. >>> >>> I would rather not add code that is not HTML strict safe if possible >>> to the rendering. >>> >>> >>> On Tue, Jul 10, 2012 at 10:00 AM, Cédric Durmont <[email protected]> wrote: >>>> 2012/6/19 Scott O'Bryan <[email protected]>: >>>> >>>>> If there is some >>>>> functionality you'd like to see in Trinidad, please open up a >>>>> discussion on the dev list about it. We'd like to hear from you. >>>> >>>> Sorry to jump in the conversation that late, I've been quite busy recently. >>>> I filed a patch in TRINIDAD-1107 quite some time ago. I do know it's >>>> not the most elegant piece of code I've ever written, and it's still >>>> far from perfect, but : >>>> - the new functionality ("height" attribute in tr:table) breaks >>>> nothing as long as it is not used, so this shouldn't affect Trinidad's >>>> stability, >>>> - We use it extensively in one of our softwares. We have 20+ clients >>>> (something between 50-100 users) using it in production on a daily >>>> basis and experience no trouble with it >>>> - More feedback and/or patches (who knows) would only make it better. >>>> >>>> I'd be happy to contribute small improvements to Trinidad in the >>>> future, as long as it's taken into account by the dev team. I don't >>>> say you should accept blindly anything, but at least give a feedback, >>>> so I can improve the patch a eventually have it accepted. >>>> >>>> Anyway, thanks for your commitment on Trinidad, which is still a neat >>>> piece of code IMHO. >>>> >>>> Regards, >>>> Cedric Durmont
