On Mon, Jun 8, 2015 at 9:43 AM, Kevin Burton <bur...@spinn3r.com> wrote:
> > Advisories break when using the memory store. A warning that a null > pointer > > > > exception was caught goes to the log but the advisories aren’t raised. > > > > > > OK, thanks for sharing. Have you created a bug report for it? If not, > can > > you do that so it doesn't get lost? > > > > > I think I did.. I will verify. > > > > > > That's what I'm not sure about; I don't know whether there are situations > > where we can concurrently attempt to add and remove consumers (maybe in > the > > scenario where a broker-to-broker network connection fails over?), nor > > whether there are situations where we might try to get values from both > > maps but where only one of the two is populated because we're in the > middle > > of an addition or a deletion. Maybe someone else who's got more > experience > > than me with that code can say whether it's a concern.. > > > > Another thing I was thinking about was the ability to just disable this > feature in JMX. But maybe that’s not needed if it’s eventually fixed. > Allowing it to be turned on and off feels like overkill in this case, so I'd say just implement the fix without the option to turn it on/off. No one would know when it was appropriate to use it (or not), so don't give people the option. Tim
