PR sent: https://github.com/apache/activemq-artemis/pull/3516




On Tue, Mar 23, 2021 at 5:29 PM Clebert Suconic <[email protected]>
wrote:

> I'm finalizing the change.. it should be committed soon today or tomorrow.
>
> On Tue, Mar 23, 2021 at 5:28 PM Clebert Suconic <[email protected]>
> wrote:
>
>> you ok to build one from master, or should I prepare one to be downloaded?
>>
>> On Tue, Mar 23, 2021 at 4:42 PM CASAUX Nicolas <
>> [email protected]> wrote:
>>
>>> Thanks Clebert!
>>> I'm glad to know that there is an actual bug! 🙂
>>> I'll be happy to test your snapshot version.
>>>
>>> ________________________________
>>> De : Clebert Suconic <[email protected]>
>>> Envoyé : mardi 23 mars 2021 20:14
>>> À : [email protected] <[email protected]>
>>> Objet : Re: ActiveMQ Artemis - resource limits - max-queues issue
>>>
>>>
>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FARTEMIS-3204&amp;data=04%7C01%7Cnicolas.casaux%40soprasteria.com%7Caf3adf19b8514aab005008d8ee2ff0e6%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C637521236968291490%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=dN%2F%2BeuX4yapWEA9S7UFD60otnoI%2Bn81yxt3c%2BABh0VE%3D&amp;reserved=0
>>>
>>> On Tue, Mar 23, 2021 at 3:07 PM Clebert Suconic
>>> <[email protected]> wrote:
>>> >
>>> > It is a bug, there's a NullPointerException causing the issue...
>>> >
>>> > I'm sending a fix.... and I will provide you a snapshot to try it out.
>>> >
>>> > On Tue, Mar 23, 2021 at 10:14 AM Clebert Suconic
>>> > <[email protected]> wrote:
>>> > >
>>> > > Ok, let me run a test then.. let me work on it for 1 or 2 hours...
>>> brb
>>> > >
>>> > > On Tue, Mar 23, 2021 at 10:13 AM CASAUX Nicolas
>>> > > <[email protected]> wrote:
>>> > > >
>>> > > > Yes, I did restart the broker each time to be sure. In the log,
>>> the "resource" part does not seem to be hot reloaded.
>>> > > >
>>> > > > -----Message d'origine-----
>>> > > > De : Clebert Suconic <[email protected]>
>>> > > > Envoyé : mardi 23 mars 2021 15:11
>>> > > > À : [email protected]
>>> > > > Objet : Re: ActiveMQ Artemis - resource limits - max-queues issue
>>> > > >
>>> > > > I did not realize you set the limit at 500.
>>> > > > >>  When I set a high value to <max-queues> like "500", I still
>>> have the
>>> > > > >> problem
>>> > > >
>>> > > > Did you restart the broker when you set the limit higher? I am not
>>> sure this value is reloaded upon change. it could be an enhancement to
>>> reload it upon modification.
>>> > > >
>>> > > > On Tue, Mar 23, 2021 at 9:43 AM CASAUX Nicolas <
>>> [email protected]> wrote:
>>> > > > >
>>> > > > > 1) I already tried with another user, but will retry to be sure.
>>> > > > > 2) If you were right about the "admin" user, I shouldn't have a
>>> problem when I set the value to 500. There's no way there are 500 queues
>>> already there when you create a new instance.
>>> > > > >
>>> > > > > -----Message d'origine-----
>>> > > > > De : Clebert Suconic <[email protected]> Envoyé : mardi
>>> 23
>>> > > > > mars 2021 14:38 À : [email protected] Objet : Re:
>>> ActiveMQ
>>> > > > > Artemis - resource limits - max-queues issue
>>> > > > >
>>> > > > > The problem I see is that you used admin, and set a limit on
>>> admin.
>>> > > > >
>>> > > > > I believe every queue created on broker.xml (including DLQ,
>>> etc..) will belong to admin. that means you won't be able to create any
>>> more than 3 queues, and the broker.xml will already pass that limit.
>>> > > > >
>>> > > > > Can you try with creating a new user to test this usecase?
>>> > > > >
>>> > > > > On Tue, Mar 23, 2021 at 6:03 AM CASAUX Nicolas <
>>> [email protected]> wrote:
>>> > > > > >
>>> > > > > > I used the 2.17.0 version.
>>> > > > > > Thanks!
>>> > > > > >
>>> > > > > > -----Message d'origine-----
>>> > > > > > De : Jean-Baptiste Onofre <[email protected]> Envoyé : mardi 23
>>> mars
>>> > > > > > 2021 11:02 À : [email protected] Objet : Re: ActiveMQ
>>> > > > > > Artemis
>>> > > > > > - resource limits - max-queues issue
>>> > > > > >
>>> > > > > > Hmmm, weird.
>>> > > > > >
>>> > > > > > Let me try to reproduce. What’s your Artemis version ?
>>> > > > > >
>>> > > > > > Regards
>>> > > > > > JB
>>> > > > > >
>>> > > > > > > Le 23 mars 2021 à 11:00, CASAUX Nicolas <
>>> [email protected]> a écrit :
>>> > > > > > >
>>> > > > > > > Hello JB,
>>> > > > > > >
>>> > > > > > > I did the test with a "fresh instance", so no queue were
>>> already created.
>>> > > > > > > And even when I set a "ridiculously" high value, I encounter
>>> the same issue.
>>> > > > > > > Tests were made with the "admin" user, and with another user
>>> I created also.
>>> > > > > > >
>>> > > > > > > Nicolas
>>> > > > > > >
>>> > > > > > > -----Message d'origine-----
>>> > > > > > > De : Jean-Baptiste Onofre <[email protected]> Envoyé : mardi
>>> 23 mars
>>> > > > > > > 2021 10:57 À : [email protected] Objet : Re:
>>> ActiveMQ
>>> > > > > > > Artemis
>>> > > > > > > - resource limits - max-queues issue
>>> > > > > > >
>>> > > > > > > Hi Nicolas,
>>> > > > > > >
>>> > > > > > > And the user match I guess ?
>>> > > > > > >
>>> > > > > > > The max-queues is the number of queues that the user can
>>> create. Maybe your user already reach the queue numbers ?
>>> > > > > > >
>>> > > > > > > Regards
>>> > > > > > > JB
>>> > > > > > >
>>> > > > > > >> Le 23 mars 2021 à 10:46, CASAUX Nicolas <
>>> [email protected]> a écrit :
>>> > > > > > >>
>>> > > > > > >> Hello,
>>> > > > > > >>
>>> > > > > > >> I'm currently trying to set-up some resource limits with
>>> ActiveMQ Artemis. I have no problem with the "max-connections" limit, which
>>> works fine.
>>> > > > > > >> However, I cannot manage to use the "max-queues" resource
>>> limit. As soon I add it in the broker.xml file, I can't subscribe to any
>>> address.
>>> > > > > > >>
>>> > > > > > >> Steps to reproduce:
>>> > > > > > >>
>>> > > > > > >> 1.  I use Artemis 2.17.0
>>> > > > > > >> 2.  I create a new instance
>>> > > > > > >> 3.  I add this config to broker.xml file:
>>> > > > > > >> <resource-limit-settings>
>>> > > > > > >>             <resource-limit-setting match="admin">
>>> > > > > > >>
>>>  <max-connections>5</max-connections>
>>> > > > > > >>                           <max-queues>3</max-queues>
>>> > > > > > >>             </resource-limit-setting>
>>> </resource-limit-settings>
>>> > > > > > >>
>>> > > > > > >> 1.  Start the instance
>>> > > > > > >> 2.  Try to connect with a Stomp over websocket client
>>> > > > > > >>
>>> > > > > > >> When I try to subscribe to an address, I get this error in
>>> Artemis Console:
>>> > > > > > >> AMQ332069: Sent ERROR frame to STOMP client
>>> /0:0:0:0:0:0:0:1:49225:
>>> > > > > > >> AMQ339016 Error creating subscription subscription/Orders
>>> But I have 0 queue created so far...
>>> > > > > > >>
>>> > > > > > >> A few more remarks:
>>> > > > > > >>
>>> > > > > > >> 1.  When I change the value of <max-queues> to "-1", I have
>>> no problem to connect with a Stomp over websocket client.
>>> > > > > > >> 2.  When I set a high value to <max-queues> like "500", I
>>> still
>>> > > > > > >> have the problem  3.  I have the same problem with a JMS
>>> client.
>>> > > > > > >>
>>> > > > > > >> Thanks for your help!
>>> > > > > > >>
>>> > > > > > >> Nicolas
>>> > > > > > >>
>>> > > > > > >
>>> > > > > >
>>> > > > >
>>> > > > >
>>> > > > > --
>>> > > > > Clebert Suconic
>>> > > >
>>> > > >
>>> > > >
>>> > > > --
>>> > > > Clebert Suconic
>>> > >
>>> > >
>>> > >
>>> > > --
>>> > > Clebert Suconic
>>> >
>>> >
>>> >
>>> > --
>>> > Clebert Suconic
>>>
>>>
>>>
>>> --
>>> Clebert Suconic
>>>
>>
>>
>> --
>> Clebert Suconic
>>
>
>
> --
> Clebert Suconic
>


-- 
Clebert Suconic

Reply via email to