On Friday, April 25, 2014 10:39:27 PM CEST, Sebastiano Pilla wrote:
If removing those #pragmas makes things worse for everyone else, then please don't do it. I'd rather see you document the minimum GCC version known to compile the 3.2.0 sources, just as you documented the minimum PostgreSQL version needed to run it.

The minimum postgresql version has the pleasant characteristic that we can find out what it is easily. Centos Postgresql is effectively the same as ubuntu postgresql and both of them are the same as freebsd postgresql. Gcc is not so friendly.

What has to give is my -Wall -Werror (ie. a demand that the source be completely free of warnings). Avoiding all warnings is too much hassle on gcc.

Arnt

Reply via email to