On Tuesday, July 8, 2014 9:19:47 AM CEST, NSS Ltd wrote:
OK, patch for the *very* work in progress setannotation/getannotation
Missing the patch to schema/schema.pg.
There's a helper class you might want to use to take care of contention
robustly. Have a look at message/helperrowcreator.cpp; there's a class
called FlagCreator there that creates flags in just the same way that you
create annotations. Most of FlagCreator inherits a larger class,
HelperRowCreator.
You might copy FlagCreator into a new class, AnnotationCreator or
MetadataCreator. That should simplify getannotation and setannotation quite
a bit.
There's a list of mailboxes as strings; I think it would be better to have
a List<Mailbox> and produce that by calling some of the static functions in
imap/handlers/listext.cpp.
Overall I find it quite good for a work in progress.
Arnt
