Thanks! I'll make sure these changes are applied for 2.1. Matt 2009/3/30 tibi <t...@dds.nl>
> and pmd errors are gone too: > > changed these: > > * org.appfuse.webapp.action.UserAction > > * org.appfuse.webapp.listener.UserCounterListener > > * org.appfuse.webapp.taglib.CountryTag > > * org.appfuse.webapp.util.RequestUtil > > this is the jira: > http://issues.appfuse.org/browse/APF-1145 > > have fun. > > ow this can be closed i think: > http://issues.appfuse.org/browse/APF-307 > > > > tibi wrote: > > jira made: > > > > http://issues.appfuse.org/browse/APF-1144 > > > > hope it can be added! > > > > thanks > > > > > > > > tibi wrote: > > > >> ok done. > >> > >> i will add what i have done to the jira bug i will make. > >> > >> here is the list to get to 0 checkstyle errors: > >> > >> > >> * Changed some self made classes in model > >> > >> * Moved to test tree > >> > >> * org.appfuse.service.BaseManagerTestCase > >> > >> * org.appfuse.service.impl.BaseManagerMockTestCase > >> > >> * org.appfuse.webapp.action.BaseActionTestCase > >> > >> * Changed checkstyle.xml: > >> > >> * <module name="LineLength"> > >> <property name="max" value="120"/> > >> <!-- ignore rows starting with a * @see and long word--> > >> <property name="ignorePattern" value="^ *\* \...@see *[^ ]+$"/> > >> </module> > >> > >> * Changed > >> * org.appfuse.util.DateUtil > >> > >> * org.appfuse.webapp.action.BaseAction > >> > >> * org.appfuse.webapp.action.BaseActionTestCase > >> > >> * org.appfuse.webapp.action.DateConverter > >> > >> * org.appfuse.webapp.action.FileUploadAction > >> > >> * org.appfuse.webapp.action.UserAction > >> > >> * org.appfuse.webapp.filter.StaticFilter > >> > >> * org.appfuse.webapp.listener.StartupListener > >> > >> * org.appfuse.model.Role > >> > >> * org.appfuse.service.BaseManagerTestCase > >> > >> * org.appfuse.service.impl.BaseManagerMockTestCase > >> > >> * org.appfuse.util.ConvertUtil > >> > >> * org.appfuse.util.DateUtil > >> > >> * Changed org.appfuse.dao.BaseDaoTestCase > >> > >> * Changed org.appfuse.dao.hibernate.UserDaoHibernate > >> > >> * Removed App.java > >> > >> * Changed org.appfuse.Constants.java > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: users-unsubscr...@appfuse.dev.java.net > >> For additional commands, e-mail: users-h...@appfuse.dev.java.net > >> > >> > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscr...@appfuse.dev.java.net > > For additional commands, e-mail: users-h...@appfuse.dev.java.net > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@appfuse.dev.java.net > For additional commands, e-mail: users-h...@appfuse.dev.java.net > >