matt et al, when you patch the genericMangerImpl please take care of my mistakes (sorry)
http://issues.appfuse.org/browse/APF-1146#action_12665 tibi ok added the file to the cobertura jirra: http://issues.appfuse.org/browse/APF-1146 i did not jet expose the getAllDistinct(); tibi tibi wrote: > ok i will try. > but making patches is getting more difficult because my code is getting > out of synch with the apffuse code. > > > > Matt Raible wrote: > >> Yes and yes. >> >> Matt >> >> On Wed, Apr 1, 2009 at 4:16 AM, tibi <t...@dds.nl >> <mailto:t...@dds.nl>> wrote: >> >> >> continuing with test coverage i stumbled opun the GenericManager. >> There is no test at all. >> >> I made one simple test to check all methods. i hit the dao and >> database >> with this test. i'm not sure how strict you guy's are. >> its no junit test any more. but it is a good test. >> >> do you want to have it? >> >> secondly i see this mothod: >> /** >> * Gets all records without duplicates. <p>Note that if you use >> this >> method, it is imperative that your model >> * classes correctly implement the hashcode/equals methods</p> >> * @return List of populated objects >> */ >> List<T> getAllDistinct(); >> >> is in the dao but not in the genericManager. should this method be >> exposed to?? >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@appfuse.dev.java.net >> <mailto:users-unsubscr...@appfuse.dev.java.net> >> For additional commands, e-mail: users-h...@appfuse.dev.java.net >> <mailto:users-h...@appfuse.dev.java.net> >> >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@appfuse.dev.java.net > For additional commands, e-mail: users-h...@appfuse.dev.java.net > > > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@appfuse.dev.java.net For additional commands, e-mail: users-h...@appfuse.dev.java.net --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@appfuse.dev.java.net For additional commands, e-mail: users-h...@appfuse.dev.java.net
