Jon:
Patch applied - thanks. Re. lookup frequency - that's another questions that I'll leave for Alex.
Cheers, Steve.
Jon Elson-Green wrote:
Stephen McConnell wrote:
Jon Elson-Green wrote:My brain is already reeling trying to come to terms with all this merlin stuff but here goes.
Whenever I run merlin from the command line I see 2 of these:
Skipping line - could not find '=' in line: ''
After tracking it down to avalon/util/env/Env.java it's seems that this is caused by the standard IFS shell variable, (with a newline in it).
Although its harmless, sometimes I see it 8 times in Merlin startup, before I hack it to skip parsing IFS or hide the error message is there any chance of a maintainer dealing with this as an issue?
Any chance you could post a patch?
Cheers, Stephen.
My original debug output was:
: 'IFS= ' : '' Skipping line - could not find '=' in line: '' : 'TERM=Eterm'
So I'm only skipping printing a message on empty lines, if by chance someone else IFS is in a different order like \n\t this won't work, I have wondered if it really needs to parse the environment 10 times on a simple merlin run though ;)
Jon
RCS file: /home/cvspublic/avalon/util/env/src/java/org/apache/avalon/util/env/Env.java,v
retrieving revision 1.3
diff -u -b -B -r1.3 Env.java
--- Env.java 17 Dec 2003 04:49:20 -0000 1.3
+++ Env.java 21 Jan 2004 00:56:37 -0000
@@ -348,8 +348,10 @@
if ( -1 == l_idx )
{ + if (l_line.length()!=0) {
System.err.println( "Skipping line - could not find '=' in"
+ " line: '" + l_line + "'" ) ;
+ }
continue ;
}
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--
|------------------------------------------------| | Magic by Merlin | | Production by Avalon | | | | http://avalon.apache.org/merlin | | http://dpml.net/merlin/distributions/latest | |------------------------------------------------|
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
