Hi,
Actually did something like that, using a hot patch override of the
original function (I try to avoid forking the bot code, but did have to do
that with the www_base code, not planning to do that with the whole code).
However, I at least had some problems using the "files" values from the
data in the template, and when I disabled that part of the template I got
an exception somewhere else (in code I did not touch, at least directly)
File "buildbot/reporters/notifier.py", line 188, in
buildComplete
if self.isMessageNeeded(build):
File "buildbot/reporters/notifier.py", line 197, in
isMessageNeeded
builder = build['builder']
builtins.KeyError: 'builder'
It could be that the way I implemented by task broke something, but AFAICT
my code esssentially did the same as the main code (if in a different way,
and as a separate step).
At present I have had to back out all the mail related changes I did.
On Fri, 22 Feb 2019 10:20:36 +0100, Pierre Tardy <[email protected]> wrote:
The list of changes nowadays is available via *path: *
/builds/{buildid}/changes
http://docs.buildbot.net/2.0.1/developer/rest.html#id10
which is also available via data api, so you can submit a PR with
something
like this:
https://github.com/buildbot/buildbot/blob/fb0afec8c6dd44f7d1fbe78eaef1938d1c8472ed/master/buildbot/reporters/utils.py#L94-L97
Regards,
Pierre
if wantChanges:
buildchanges = yield defer.gatherResults(
[master.data.get(("builds", build['buildid'], 'changes'))
for build in builds])
On Wed, Feb 20, 2019 at 6:39 PM Yngve N. Pettersen <[email protected]>
wrote:
Hi,
I am in the process of deploying a new autobuilder based on Buildbot
v2.0.0, and currently one of the few missing features of the system
compared to the old is that the changelog entires for the build are
missing.
We have this in email notifications from our current system, based on
Chromium's buildbot 0.8.4ish, although that was a customization of the
buildbot code.
Based on what I can see there is no way to retrieve those data from the
email template, and AFAICT the
master.buildbot.reporters.utils.getDetailsForBuilds function does not
extract that information.
Am I missing something, or is the list of changes missing?
--
Sincerely,
Yngve N. Pettersen
Vivaldi Technologies AS
_______________________________________________
users mailing list
[email protected]
https://lists.buildbot.net/mailman/listinfo/users
--
--
Sincerely,
Yngve N. Pettersen
Vivaldi Technologies AS
_______________________________________________
users mailing list
[email protected]
https://lists.buildbot.net/mailman/listinfo/users
