On Thu, Feb 12, 2009 at 10:10 PM, Ittay Dror <[email protected]> wrote:
> > > Matthieu Riou wrote: > > On Wed, Feb 11, 2009 at 10:43 PM, Ittay Dror <[email protected]> wrote: >> >> >> >>> Matthieu Riou wrote: >>> >>> On Wed, Feb 11, 2009 at 11:32 AM, Ittay Dror <[email protected]> wrote: >>> >>> >>>> >>>> >>>> >>>>> Assaf Arkin wrote: >>>>> >>>>> Specs really really help. A patch could look simple and trivial, maybe >>>>> >>>>> >>>>> >>>>> >>>>>> it's >>>>>> a one line fix, but writing the spec and then accepting the patch is >>>>>> more >>>>>> work than accepting a tested patch. >>>>>> >>>>>> If you can't figure out how to fix something, but can at least write a >>>>>> spec >>>>>> to prove it's broken, that's also enormously helpful. The fix may end >>>>>> up >>>>>> to >>>>>> be trivial to someone else, just by running the spec and looking at >>>>>> the >>>>>> stack trace. >>>>>> >>>>>> So spec as much as possible. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> I find the current way of submitting patches / specs to be >>>>> unproductive. >>>>> It's hard for people to comment on a patch: you see an email about a >>>>> patch, >>>>> need to open the issue in the browser, download the patch, read, and >>>>> then >>>>> the only way to comment is writing an out-of-line comment in jira. and >>>>> of >>>>> course people follow jira notices far less than the "regular" mailing >>>>> lists. >>>>> >>>>> >>>>> >>>>> >>>> Care to propose an alternative? FWIW, it's how all Apache projects work. >>>> >>>> >>>> >>>> >>> well, i like how the git community works. people just send an email to >>> the >>> mailing list with '[PATCH]', if the patch is interesting, people reply >>> with >>> comments, usually very useful (potential bugs, code conventions), the >>> person >>> can then fix the patch and resubmit. >>> >>> >>> >>>> >>>> >>>> >>>>> Also, there are no clear coding conventions to follow. Finally, I >>>>> don't >>>>> remember seeing someone's patch being accepted. >>>>> >>>>> >>>>> >>>>> >>>>> >>>> Can you substantiate this claim? I can find patches that have been >>>> applied >>>> very easily in Jira. >>>> >>>> >>>> >>>> >>> Like I said, I don't remember any being accepted. I may be wrong, if so, >>> my >>> appologies. >>> >>> >>> >> >> Well, I'm not going to build any statistics but if I check recently closed >> / >> resolved issues, I see many of them like (just a recent sample): >> >> https://issues.apache.org/jira/browse/BUILDR-192 >> https://issues.apache.org/jira/browse/BUILDR-214 (which actually comes >> from >> you I think) >> https://issues.apache.org/jira/browse/BUILDR-193 >> >> There are actually quite a few other small fixes coming from you. And new >> committers like Victor and Antoine have been voted in after contributing >> several great improvements. So I'm sort of puzzled by the "no patch get >> accepted" argument. >> >> > it was a feeling and i apologize for not substantiating it. sorry for any > hurt feelings. > Oh no worries, no hurt feelings here :) Cheers, Matthieu
